Re: [PATCH 3/3] tty: serial: samsung: Remove unused artpec-8 specific code

Krzysztof Kozlowski
2025-09-11T14:29:36Z

On 11/09/2025 16:27, Geert Uytterhoeven wrote:
> Hi Ravi,
>
> On Thu, 11 Sept 2025 at 16:17, Ravi Patel <ravi.patel@samsung.com> wrote:
>> Since ARTPEC-8 is using exynos8895 driver data, remove the unused
>> artpec-8 specific driver data.
>>
>> ARTPEC-8 is using exynos4210 for earlycon, so earlycon code
>> for ARTPEC-8 is also not required.
>>
>> Signed-off-by: Ravi Patel <ravi.patel@samsung.com>
>
> Thanks for your patch!
>
>> --- a/drivers/tty/serial/samsung_tty.c
>> +++ b/drivers/tty/serial/samsung_tty.c
>
>> @@ -2655,8 +2621,6 @@ static const struct of_device_id s3c24xx_uart_dt_match[] = {
>> .data = S5L_SERIAL_DRV_DATA },
>> { .compatible = "samsung,exynos850-uart",
>> .data = EXYNOS850_SERIAL_DRV_DATA },
>> - { .compatible = "axis,artpec8-uart",
>> - .data = ARTPEC8_SERIAL_DRV_DATA },
>> { .compatible = "google,gs101-uart",
>> .data = GS101_SERIAL_DRV_DATA },
>> { .compatible = "samsung,exynos8895-uart",
>> @@ -2828,8 +2792,6 @@ OF_EARLYCON_DECLARE(s5pv210, "samsung,s5pv210-uart",
>> s5pv210_early_console_setup);
>> OF_EARLYCON_DECLARE(exynos4210, "samsung,exynos4210-uart",
>> s5pv210_early_console_setup);
>> -OF_EARLYCON_DECLARE(artpec8, "axis,artpec8-uart",
>> - s5pv210_early_console_setup);
>>
>> static int __init gs101_early_console_setup(struct earlycon_device *device,
>> const char *opt)
>
> Removing these breaks backwards-compatibility with existing DTBs,
> which lack the new "samsung,exynos8895-uart" fallback compatible value.

This was just applied, so ABI break would be fine. It should be however
clearly expressed in the commit msg.

I have a feeling that not much testing was happening in Samsung around
this patchset and only now - after I applied it - some things happen.
But it is damn too late, my tree is already closed which means this is
going to be the ABI.

>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds

Best regards,
Krzysztof