From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Ionut Nechita (Wind River)" <ionut.nechita@windriver.com>,
stable@kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
wander@redhat.com, chris.friesen@windriver.com,
linux-serial <linux-serial@vger.kernel.org>
Subject: Re: [PATCH v2 6.12.y 00/10] serial: 8250_dw: backport BUSY deassert series
Date: Tue, 16 Jun 2026 10:57:17 +0300 (EEST) [thread overview]
Message-ID: <6f3f1c55-be29-7b37-32d3-fab59ea6474c@linux.intel.com> (raw)
In-Reply-To: <2026061641-cozy-creatable-9a9e@gregkh>
[-- Attachment #1: Type: text/plain, Size: 1231 bytes --]
On Tue, 16 Jun 2026, Greg Kroah-Hartman wrote:
> On Wed, May 13, 2026 at 01:16:31PM +0300, Ilpo Järvinen wrote:
> > On Wed, 13 May 2026, Ionut Nechita (Wind River) wrote:
> >
> > > From: Ionut Nechita <ionut.nechita@windriver.com>
> > >
> > > Hi Greg, Ilpo,
> > >
> > > This is v2 of the 8250_dw BUSY deassert backport to 6.12.y,
> > > addressing Ilpo's review feedback on v1.
> >
> > FYI, this came up yesterday related to guard()s vs unlock variants:
> >
> > https://lore.kernel.org/linux-serial/cover.1778592805.git.jnilo@free.fr/
>
> Yeah, I'm not going to take these now, I'd like to see a lot more
> testing and some actual reasons why this is needed in this tree. So far
> windriver's track-record for backports is really low/bad so I'll just
> drop them from my review queue right now.
To be fair, it was me who strongly suggested that the backport should do
the guard() conversion as well, which contained the bug linked above (and
the cause there too, was my handiwork), while they initially kept using
open-coded lock/unlock variants which would not have been subject to that
problem.
But yes, you guys are the stable maintainers so what to take is your
decision.
--
i.
prev parent reply other threads:[~2026-06-16 7:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 6:50 [PATCH v2 6.12.y 00/10] serial: 8250_dw: backport BUSY deassert series Ionut Nechita (Wind River)
2026-05-13 6:50 ` [PATCH v2 6.12.y 01/10] serial: 8250: use serial_port_in/out() helpers Ionut Nechita (Wind River)
2026-05-13 6:50 ` [PATCH v2 6.12.y 02/10] serial: 8250_dw: Comment possible corner cases in serial_out() implementation Ionut Nechita (Wind River)
2026-05-13 6:50 ` [PATCH v2 6.12.y 03/10] serial: introduce uart_port_lock() guard()s Ionut Nechita (Wind River)
2026-05-13 6:50 ` [PATCH v2 6.12.y 04/10] serial: 8250: convert serial8250_do_shutdown() to scoped_guard() Ionut Nechita (Wind River)
2026-05-13 6:50 ` [PATCH v2 6.12.y 05/10] serial: 8250: Protect LCR write in shutdown Ionut Nechita (Wind River)
2026-05-13 6:50 ` [PATCH v2 6.12.y 06/10] serial: 8250_dw: Avoid unnecessary LCR writes Ionut Nechita (Wind River)
2026-05-13 6:50 ` [PATCH v2 6.12.y 07/10] serial: 8250: Add serial8250_handle_irq_locked() Ionut Nechita (Wind River)
2026-05-13 6:50 ` [PATCH v2 6.12.y 08/10] serial: 8250_dw: Rework dw8250_handle_irq() locking and IIR handling Ionut Nechita (Wind River)
2026-05-13 6:50 ` [PATCH v2 6.12.y 09/10] serial: 8250_dw: Rework IIR_NO_INT handling to stop interrupt storm Ionut Nechita (Wind River)
2026-05-13 6:50 ` [PATCH v2 6.12.y 10/10] serial: 8250_dw: Ensure BUSY is deasserted Ionut Nechita (Wind River)
2026-05-13 10:16 ` [PATCH v2 6.12.y 00/10] serial: 8250_dw: backport BUSY deassert series Ilpo Järvinen
2026-06-16 3:43 ` Greg Kroah-Hartman
2026-06-16 7:57 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f3f1c55-be29-7b37-32d3-fab59ea6474c@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=chris.friesen@windriver.com \
--cc=gregkh@linuxfoundation.org \
--cc=ionut.nechita@windriver.com \
--cc=linux-serial@vger.kernel.org \
--cc=stable@kernel.org \
--cc=wander@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox