From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5FD5EB64D9 for ; Mon, 10 Jul 2023 10:07:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231637AbjGJKHP (ORCPT ); Mon, 10 Jul 2023 06:07:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231627AbjGJKG4 (ORCPT ); Mon, 10 Jul 2023 06:06:56 -0400 Received: from out30-97.freemail.mail.aliyun.com (out30-97.freemail.mail.aliyun.com [115.124.30.97]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 87B3F4215; Mon, 10 Jul 2023 03:03:46 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R161e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045176;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0Vn109gM_1688983371; Received: from 30.97.48.56(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0Vn109gM_1688983371) by smtp.aliyun-inc.com; Mon, 10 Jul 2023 18:02:53 +0800 Message-ID: <6f5ca23d-4f23-4030-2196-35026e936145@linux.alibaba.com> Date: Mon, 10 Jul 2023 18:03:12 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 2/2] serial: sprd: Fix DMA buffer leak issue To: Chunyan Zhang , Greg Kroah-Hartman , Jiri Slaby Cc: linux-serial@vger.kernel.org, Orson Zhai , Chunyan Zhang , LKML References: <20230710080348.4137875-1-chunyan.zhang@unisoc.com> <20230710080348.4137875-2-chunyan.zhang@unisoc.com> From: Baolin Wang In-Reply-To: <20230710080348.4137875-2-chunyan.zhang@unisoc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On 7/10/2023 4:03 PM, Chunyan Zhang wrote: > Release DMA buffer when _probe() returns fail to avoid memory leak. > > Fixes: f4487db58eb7 ("serial: sprd: Add DMA mode support") > Signed-off-by: Chunyan Zhang LGTM. Reviewed-by: Baolin Wang > --- > drivers/tty/serial/sprd_serial.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/sprd_serial.c b/drivers/tty/serial/sprd_serial.c > index 942808517393..e1f11382fc39 100644 > --- a/drivers/tty/serial/sprd_serial.c > +++ b/drivers/tty/serial/sprd_serial.c > @@ -1203,7 +1203,7 @@ static int sprd_probe(struct platform_device *pdev) > ret = uart_register_driver(&sprd_uart_driver); > if (ret < 0) { > pr_err("Failed to register SPRD-UART driver\n"); > - return ret; > + goto free_rx_buf; > } > } > sprd_ports_num++; > @@ -1222,6 +1222,8 @@ static int sprd_probe(struct platform_device *pdev) > sprd_port[index] = NULL; > sprd_ports_num--; > uart_unregister_driver(&sprd_uart_driver); > +free_rx_buf: > + sprd_rx_free_buf(sport); > return ret; > } >