From: Jiri Slaby <jirislaby@kernel.org>
To: Tian Tao <tiantao6@hisilicon.com>, gregkh@linuxfoundation.org
Cc: linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org,
Hyunki Koo <hyunki00.koo@samsung.com>
Subject: Re: [PATCH] tty: serial: samsung_tty: remove set but not used variables
Date: Fri, 23 Apr 2021 11:55:07 +0200 [thread overview]
Message-ID: <6f8d59ca-3d28-82a9-0105-a471ee90ac1f@kernel.org> (raw)
In-Reply-To: <1619170740-63717-1-git-send-email-tiantao6@hisilicon.com>
On 23. 04. 21, 11:39, Tian Tao wrote:
> The value of 'ret' is not used, so just delete it.
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> ---
> drivers/tty/serial/samsung_tty.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
> index d9e4b67..d269d75 100644
> --- a/drivers/tty/serial/samsung_tty.c
> +++ b/drivers/tty/serial/samsung_tty.c
> @@ -2220,7 +2220,6 @@ static int s3c24xx_serial_probe(struct platform_device *pdev)
> default:
> dev_warn(&pdev->dev, "unsupported reg-io-width (%d)\n",
> prop);
> - ret = -EINVAL;
> break;
Added by:
commit 57253ccd5831e7e5720c433437775c3e6b7d0c72
Author: Hyunki Koo <hyunki00.koo@samsung.com>
Date: Wed May 6 17:02:40 2020 +0900
serial: samsung: 32-bit access for TX/RX hold registers
Hyunki, what was the intention with "ret" here?
> }
> }
>
--
js
suse labs
prev parent reply other threads:[~2021-04-23 9:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 9:39 [PATCH] tty: serial: samsung_tty: remove set but not used variables Tian Tao
2021-04-23 9:47 ` Greg KH
2021-04-23 9:54 ` tiantao (H)
2021-04-23 10:14 ` Greg KH
2021-04-26 6:45 ` Krzysztof Kozlowski
2021-04-26 6:56 ` Greg KH
2021-04-26 6:57 ` Krzysztof Kozlowski
2021-04-23 9:55 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f8d59ca-3d28-82a9-0105-a471ee90ac1f@kernel.org \
--to=jirislaby@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hyunki00.koo@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=tiantao6@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).