From: Jiri Slaby <jirislaby@kernel.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: gregkh@linuxfoundation.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: Re: [PATCH 1/5] serial: 8250: extract serial8250_init_mctrl()
Date: Tue, 24 Jun 2025 07:29:35 +0200 [thread overview]
Message-ID: <70f3d715-be10-4e2a-aad4-bdb3c33d9159@kernel.org> (raw)
In-Reply-To: <aFmYwcO9tJ4byxjz@surfacebook.localdomain>
On 23. 06. 25, 20:11, Andy Shevchenko wrote:
> Mon, Jun 23, 2025 at 09:46:02AM +0200, Jiri Slaby (SUSE) kirjoitti:
>> After commit 795158691cc0 ("serial: 8250: extract
>> serial8250_initialize()"), split serial8250_initialize() even more --
>> the mctrl part of this code can be separated into
>> serial8250_init_mctrl() -- done now.
>
> ...
>
>> +static void serial8250_init_mctrl(struct uart_port *port)
>> +{
>> + struct uart_8250_port *up = up_to_u8250p(port);
>> +
>> + if (up->port.flags & UPF_FOURPORT) {
>> + if (!up->port.irq)
>> + up->port.mctrl |= TIOCM_OUT1;
>
> I am not sure I understand why it was changed from using port directly to
> up->port.
Ugh, that's a mistake. During rebase likely. Thanks for catching.
--
js
suse labs
next prev parent reply other threads:[~2025-06-24 5:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 7:46 [PATCH 0/5] tty: fixes on top of summer cleanup Jiri Slaby (SUSE)
2025-06-23 7:46 ` [PATCH 1/5] serial: 8250: extract serial8250_init_mctrl() Jiri Slaby (SUSE)
2025-06-23 18:11 ` Andy Shevchenko
2025-06-24 5:29 ` Jiri Slaby [this message]
2025-06-23 7:46 ` [PATCH 2/5] serial: 8250: extract serial8250_iir_txen_test() Jiri Slaby (SUSE)
2025-06-23 7:46 ` [PATCH 3/5] serial: 8250: rename lsr_TEMT, iir_NOINT to lowercase Jiri Slaby (SUSE)
2025-06-23 7:46 ` [PATCH 4/5] serial: 8250: document doubled "type == PORT_8250_CIR" check Jiri Slaby (SUSE)
2025-06-23 8:19 ` Andy Shevchenko
2025-06-23 7:46 ` [PATCH 5/5] tty: fix tty_port_tty_*hangup() kernel-doc Jiri Slaby (SUSE)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70f3d715-be10-4e2a-aad4-bdb3c33d9159@kernel.org \
--to=jirislaby@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).