From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v3 01/12] irqchip: armada-370-xp: add Kconfig option for the driver Date: Tue, 09 Feb 2016 16:14:32 +0100 Message-ID: <7747159.T9eeT0dC65@wuerfel> References: <1454951660-13289-1-git-send-email-gregory.clement@free-electrons.com> <1454951660-13289-2-git-send-email-gregory.clement@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <1454951660-13289-2-git-send-email-gregory.clement@free-electrons.com> Sender: linux-kernel-owner@vger.kernel.org To: Gregory CLEMENT Cc: Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , arm@kernel.org, Catalin Marinas , Will Deacon , Jonathan Corbet , Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, Tejun Heo , Hans de Goede , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Rutland , devicetree@vger.kernel.org, Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, Lior Amsalem , Nadav Haklai , Omri Itach List-Id: linux-serial@vger.kernel.org On Monday 08 February 2016 18:14:09 Gregory CLEMENT wrote: > > +config ARMADA_370_XP_IRQ > + bool > + default y if ARCH_MVEBU > + select GENERIC_IRQ_CHIP > + > Looks good. I wonder if we should also enable this for COMPILE_TEST, e.g. config ARMADA_370_XP_IRQ bool "Marvell Armada 3xx/XP/3xxx interrupt controller" if COMPILE_TEST && !ARCH_MVEBU default ARCH_MVEBU select GENERIC_IRQ_CHIP If we do this, it's probably something outside of your series that we should do for all patches, so don't worry about it here. Any opinions on the general question? Arnd