From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F149C04A6A for ; Sat, 24 Jun 2023 08:12:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232577AbjFXIM3 (ORCPT ); Sat, 24 Jun 2023 04:12:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232086AbjFXIM2 (ORCPT ); Sat, 24 Jun 2023 04:12:28 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF2A7DC for ; Sat, 24 Jun 2023 01:12:26 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-51d80d81d6eso206378a12.1 for ; Sat, 24 Jun 2023 01:12:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687594345; x=1690186345; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=jgWfgLnDBYXfvDGmBGK93+dUC4prG/sfhkKHOWCy+iE=; b=BcN0ZET2/vhS6m5PtcAFTcmo5biBSuvnTU+o+doo7zX+3gXeZTeFZKeOqNp0xWPPDW kDfKGGyPXG4O12ifWz1/qzeiNJrNiqW+iNEGHi1SadOQ3S9IU/oRfOO33qen8bcDfSvu 8DZ89+qcFQ8t903wSSbJW6eoHNSbWtKIYSnMwpXkyOxHSVl1Yf0oue4VUNbyOsE4l7rG zu2hDWoTCeh8BZ3zC4QWRN4TljlLcXOdJB45uGFqcNGxnRcIR2U9ey83S6Nn3MQNCIk7 BQB6GMqUxU0qGumADilEvZvX832T+7pOOWNtu8XGxpwVav5Y9KmizF53mGroaDK458Kb MR4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687594345; x=1690186345; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=jgWfgLnDBYXfvDGmBGK93+dUC4prG/sfhkKHOWCy+iE=; b=eFXvpb1AlENpbAzDX2zYDJ83vUgDbgD16TVFTilH0X++M/hLRUhml89XJnJhGJEo8p ejQcKACki+DZ5Rv3or03cCIjlBI2no1ATQKAkwt13OPDu9o0iQ4QkrQwTqKQ8vsVy8PX 7wjp+vRemv8G97oje082F41eKIWUc5cOiJOl7/ASBhWC4Q6WMViqyL7cFkkCqbstr4HP xIYdzLT6PGD0iQM8JALh6OdwIPAW1ccY6KYvCfotkqNl0W5HQODMtUZLkpVxRA+vf9Fa B4jNUzCUkVFskYhOOIsSrxDmG9/lH6r6PbBk+gaMHLQugI4hmOhCZAYAygy16eRQscfQ GO8w== X-Gm-Message-State: AC+VfDyEFPc+ghiZ2nXpX9u+6SY6yvcYJNu79i0PeKErp5Dpks7pA0l4 K5Kl2YEMZqiJw/zNx6sGX3Dsqw== X-Google-Smtp-Source: ACHHUZ5Rew0XhfwsYlFMUaLNmLSeNdfJi5OvwMCRiF/HMRv0s1S3Hjzr6jtGZts9Zub1Ru8qB3Xfiw== X-Received: by 2002:a05:6402:1389:b0:51a:441f:75d7 with SMTP id b9-20020a056402138900b0051a441f75d7mr14078910edv.6.1687594340214; Sat, 24 Jun 2023 01:12:20 -0700 (PDT) Received: from [192.168.1.20] ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id q18-20020a056402033200b0051be83f75e6sm408661edw.95.2023.06.24.01.12.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 24 Jun 2023 01:12:19 -0700 (PDT) Message-ID: <796a0cf2-2411-26e4-5b53-53d560936b7a@linaro.org> Date: Sat, 24 Jun 2023 10:12:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2 45/45] ARM: dts: at91: sam9x75_curiosity: add device tree for sam9x75 curiosity board Content-Language: en-US To: Varshini Rajendran , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, claudiu.beznea@microchip.com, mturquette@baylibre.com, sboyd@kernel.org, herbert@gondor.apana.org.au, davem@davemloft.net, vkoul@kernel.org, tglx@linutronix.de, maz@kernel.org, lee@kernel.org, ulf.hansson@linaro.org, tudor.ambarus@linaro.org, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linus.walleij@linaro.org, p.zabel@pengutronix.de, olivia@selenic.com, a.zummo@towertech.it, radu_nicolae.pirea@upb.ro, richard.genoud@gmail.com, gregkh@linuxfoundation.org, lgirdwood@gmail.com, broonie@kernel.org, wim@linux-watchdog.org, linux@roeck-us.net, arnd@arndb.de, olof@lixom.net, soc@kernel.org, linux@armlinux.org.uk, sre@kernel.org, jerry.ray@microchip.com, horatiu.vultur@microchip.com, durai.manickamkr@microchip.com, andrew@lunn.ch, alain.volmat@foss.st.com, neil.armstrong@linaro.org, mihai.sain@microchip.com, eugen.hristev@collabora.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org, dmaengine@vger.kernel.org, linux-i2c@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, netdev@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org, linux-spi@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-usb@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-pm@vger.kernel.org Cc: Hari.PrasathGE@microchip.com, cristian.birsan@microchip.com, balamanikandan.gunasundar@microchip.com, manikandan.m@microchip.com, dharma.b@microchip.com, nayabbasha.sayed@microchip.com, balakrishnan.s@microchip.com References: <20230623203056.689705-1-varshini.rajendran@microchip.com> <20230623203056.689705-46-varshini.rajendran@microchip.com> From: Krzysztof Kozlowski In-Reply-To: <20230623203056.689705-46-varshini.rajendran@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On 23/06/2023 22:30, Varshini Rajendran wrote: > Add device tree file for sam9x75 curiosity board. > > Signed-off-by: Varshini Rajendran > --- > arch/arm/boot/dts/Makefile | 2 + > arch/arm/boot/dts/at91-sam9x75_curiosity.dts | 336 +++++++++++++++++++ > 2 files changed, 338 insertions(+) > create mode 100644 arch/arm/boot/dts/at91-sam9x75_curiosity.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 59829fc90315..31f357f8e947 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -53,6 +53,8 @@ dtb-$(CONFIG_SOC_AT91SAM9) += \ > dtb-$(CONFIG_SOC_SAM9X60) += \ > at91-sam9x60_curiosity.dtb \ > at91-sam9x60ek.dtb > +dtb-$(CONFIG_SOC_SAM9X7) += \ > + at91-sam9x75_curiosity.dtb > dtb-$(CONFIG_SOC_SAM_V7) += \ > at91-kizbox2-2.dtb \ > at91-kizbox3-hs.dtb \ > diff --git a/arch/arm/boot/dts/at91-sam9x75_curiosity.dts b/arch/arm/boot/dts/at91-sam9x75_curiosity.dts > new file mode 100644 > index 000000000000..56d3af549201 > --- /dev/null > +++ b/arch/arm/boot/dts/at91-sam9x75_curiosity.dts > @@ -0,0 +1,336 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * at91-sam9x75_curiosity.dts - Device Tree file for Microchip SAM9X75 Curiosity board > + * > + * Copyright (C) 2023 Microchip Technology Inc. and its subsidiaries > + * > + * Author: Varshini Rajendran > + */ > +/dts-v1/; > +#include "sam9x7.dtsi" > +#include > + > +/ { > + model = "Microchip SAM9X75 Curiosity"; > + compatible = "microchip,sam9x75-curiosity", "microchip,sam9x7", "atmel,at91sam9"; > + > + aliases { > + i2c0 = &i2c6; > + i2c1 = &i2c7; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + clocks { > + clock-slowxtal { > + clock-frequency = <32768>; > + }; > + > + clock-mainxtal { > + clock-frequency = <24000000>; > + }; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_key_gpio_default>; > + status = "okay"; Why? Did you disable it? > + > + button-user { > + label = "USER"; > + gpios = <&pioC 9 GPIO_ACTIVE_LOW>; > + linux,code = ; > + wakeup-source; > + }; > + }; > + > + leds { > + compatible = "gpio-leds"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_led_gpio_default>; > + status = "okay"; Why? Did you disable it? > + > + led-0 { > + label = "red"; > + gpios = <&pioC 19 GPIO_ACTIVE_HIGH>; > + }; > + > + led-1 { > + label = "green"; > + gpios = <&pioC 21 GPIO_ACTIVE_HIGH>; > + }; > + > + led-2 { > + label = "blue"; > + gpios = <&pioC 20 GPIO_ACTIVE_HIGH>; > + linux,default-trigger = "heartbeat"; > + }; > + }; > + > + memory@20000000 { > + device_type = "memory"; > + reg = <0x20000000 0x10000000>; > + }; > +}; > + > +&dbgu { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_dbgu>; > + status = "okay"; > +}; > + > +&dma0 { > + status = "okay"; > +}; > + > +&ehci0 { > + status = "okay"; > +}; > + > +&flx6 { > + atmel,flexcom-mode = ; > + status = "okay"; > + > + i2c6: i2c@600 { > + #address-cells = <1>; > + #size-cells = <0>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_flx6_default>; > + i2c-analog-filter; > + i2c-digital-filter; > + i2c-digital-filter-width-ns = <35>; > + status = "okay"; Did you disable it? If so this should be overridden by label... > + > + mcp16502@5b { Node names should be generic. See also explanation and list of examples in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > + compatible = "microchip,mcp16502"; > + reg = <0x5b>; > + status = "okay"; Srsly, drop. > + > + regulators { > + vdd_3v3: VDD_IO { > + regulator-name = "VDD_IO"; > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3600000>; ... > +&flx7 { > + atmel,flexcom-mode = ; > + status = "okay"; > + > + i2c7: i2c@600 { > + #address-cells = <1>; > + #size-cells = <0>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_flx7_default>; > + i2c-analog-filter; > + i2c-digital-filter; > + i2c-digital-filter-width-ns = <35>; > + status = "okay"; Empty bus. Keep disabled. Anyway overrides should be done via label, not by duplicating children. > + }; > +}; > + > +&ohci0 { > + num-ports = <3>; > + atmel,vbus-gpio = <0 > + &pioC 27 GPIO_ACTIVE_HIGH > + &pioB 18 GPIO_ACTIVE_HIGH>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usb_default>; > + status = "okay"; > +}; > + > +&pinctrl { > + > + dbgu { > + pinctrl_dbgu: dbgu-0 { > + atmel,pins = + AT91_PIOA 27 AT91_PERIPH_A AT91_PINCTRL_NONE>; > + }; > + }; > + > + flexcom { > + pinctrl_flx6_default: flx6_twi { No underscors in node names. This applies everywhere. Best regards, Krzysztof