linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1] dt-bindings: serial: snps-dw-apb-uart: add dma & dma-names properties
@ 2023-02-08 17:17 Conor Dooley
  2023-02-09  9:11 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 2+ messages in thread
From: Conor Dooley @ 2023-02-08 17:17 UTC (permalink / raw)
  To: robh+dt, gregkh
  Cc: conor, Conor Dooley, krzysztof.kozlowski+dt, linux-serial,
	linux-kernel

From: Conor Dooley <conor.dooley@microchip.com>

Commit 0c559bc8abfb ("dt-bindings: serial: restrict possible child node
names") exposed the Allwinner D1 devicetrees as users of unevaluated
properties, with a slew of similar warnings now appearing during
dtbs_check:
sun20i-d1-nezha.dtb: serial@2500400: Unevaluated properties are not allowed ('dma-names', 'dmas' were unexpected)

Document the missing properties.

Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
The commit exposing it is in Rob's tree, but I figure this can go either
way as it has no dependancy.
---
 .../devicetree/bindings/serial/snps-dw-apb-uart.yaml      | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
index b9c2287c5d1e..2becdfab4f15 100644
--- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
+++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
@@ -67,6 +67,14 @@ properties:
       - const: baudclk
       - const: apb_pclk
 
+  dmas:
+    minItems: 2
+
+  dma-names:
+    items:
+      - const: rx
+      - const: tx
+
   snps,uart-16550-compatible:
     description: reflects the value of UART_16550_COMPATIBLE configuration
       parameter. Define this if your UART does not implement the busy functionality.
-- 
2.39.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v1] dt-bindings: serial: snps-dw-apb-uart: add dma & dma-names properties
  2023-02-08 17:17 [PATCH v1] dt-bindings: serial: snps-dw-apb-uart: add dma & dma-names properties Conor Dooley
@ 2023-02-09  9:11 ` Krzysztof Kozlowski
  0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-09  9:11 UTC (permalink / raw)
  To: Conor Dooley, robh+dt, gregkh
  Cc: Conor Dooley, krzysztof.kozlowski+dt, linux-serial, linux-kernel

On 08/02/2023 18:17, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
> 
> Commit 0c559bc8abfb ("dt-bindings: serial: restrict possible child node
> names") exposed the Allwinner D1 devicetrees as users of unevaluated
> properties, with a slew of similar warnings now appearing during
> dtbs_check:
> sun20i-d1-nezha.dtb: serial@2500400: Unevaluated properties are not allowed ('dma-names', 'dmas' were unexpected)
> 
> Document the missing properties.
> 
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-02-09  9:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-08 17:17 [PATCH v1] dt-bindings: serial: snps-dw-apb-uart: add dma & dma-names properties Conor Dooley
2023-02-09  9:11 ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).