Re: [PATCH 2/3] tty: remove unnecessary SERIAL_NONSTANDARD config option

[Randy Dunlap <rdunlap@infradead.org>]

On 5/4/26 6:20 PM, Ethan Nelson-Moore wrote:
> The SERIAL_NONSTANDARD config option currently only guards the
> selection of two Moxa multiport serial card drivers and the HDLC line
> discipline, so it does not significantly simplify configuration. Make
> the configuration process more straightforward by dropping this option
> and dependencies on it.
> 
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
> ---
>  arch/arm/configs/footbridge_defconfig       |  1 -
>  arch/arm/configs/lpc18xx_defconfig          |  1 -
>  arch/arm/configs/mps2_defconfig             |  1 -
>  arch/arm/configs/neponset_defconfig         |  1 -
>  arch/arm/configs/stm32_defconfig            |  1 -
>  arch/csky/configs/defconfig                 |  1 -
>  arch/loongarch/configs/loongson32_defconfig |  1 -
>  arch/loongarch/configs/loongson64_defconfig |  1 -
>  arch/mips/configs/bigsur_defconfig          |  1 -
>  arch/mips/configs/lemote2f_defconfig        |  1 -
>  arch/mips/configs/loongson2k_defconfig      |  1 -
>  arch/mips/configs/loongson3_defconfig       |  1 -
>  arch/powerpc/configs/cell_defconfig         |  1 -
>  arch/powerpc/configs/microwatt_defconfig    |  1 -
>  arch/powerpc/configs/ppc6xx_defconfig       |  1 -
>  arch/sh/configs/polaris_defconfig           |  1 -
>  arch/x86/configs/i386_defconfig             |  1 -
>  arch/x86/configs/x86_64_defconfig           |  1 -
>  drivers/tty/Kconfig                         | 18 ------------------
>  drivers/tty/serial/Kconfig                  |  4 ++--
>  tools/testing/selftests/bpf/config.x86_64   |  1 -
>  tools/testing/selftests/hid/config.common   |  1 -
>  22 files changed, 2 insertions(+), 40 deletions(-)
> 


> diff --git a/drivers/tty/Kconfig b/drivers/tty/Kconfig
> index 63b378e44a59..a9ade8bc88b2 100644
> --- a/drivers/tty/Kconfig
> +++ b/drivers/tty/Kconfig
> @@ -191,26 +191,8 @@ config LDISC_AUTOLOAD
>  
>  source "drivers/tty/serial/Kconfig"
>  
> -config SERIAL_NONSTANDARD
> -	bool "Non-standard serial port support"
> -	depends on HAS_IOMEM
> -	help
> -	  Say Y here if you have any non-standard serial boards -- boards
> -	  which aren't supported using the standard "dumb" serial driver.
> -	  This includes intelligent serial boards such as
> -	  Digiboards, etc. These are usually used for systems that need many
> -	  serial ports because they serve many terminals or dial-in
> -	  connections.
> -
> -	  Note that the answer to this question won't directly affect the
> -	  kernel: saying N will just cause the configurator to skip all
> -	  the questions about non-standard serial boards.
> -
> -	  Most people can say N here.
> -
>  config N_HDLC
>  	tristate "HDLC line discipline support"
> -	depends on SERIAL_NONSTANDARD

Here, N_HDLC used to depend on HAS_IOMEM (due to SERIAL_NONSTANDARD).
It no longer depends on HAS_IOMEM so it can be built for ARCH=um with
no build errors.

Just FYI/FWIW. Maybe add that to the commit message.

-- 
~Randy