RE: [PATCH V2] tty: serial: Fix bit order in RS485 flag definitions

[Christoph Niedermaier <cniedermaier@dh-electronics.com>]

From: Jiri Slaby [mailto:jirislaby@kernel.org]
Sent: Friday, January 19, 2024 7:36 AM
> On 18. 01. 24, 16:46, Christoph Niedermaier wrote:
>> Since the commit 93f3350c46fa ("RS485: fix inconsistencies in the
>> meaning of some variables"), the definition for bit 3 has been removed.
>> But with the switch to bit shift macros in commit 76ac8e29855b ("tty:
>> serial: Cleanup the bit shift with macro"), this gap wasn't preserved.
>> To avoid a break in user/kernel api of the system skip bit 3 again and
>> add a placeholder comment.
>>
>> Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>
>> Fixes: 76ac8e29855b ("tty: serial: Cleanup the bit shift with macro")
>> Fixes: 6056f20f27e9 ("tty: serial: Add RS422 flag to struct serial_rs485")
>> ---
> 
> This triple dash is superfluous and will likely break git am.

OK.
 
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Cc: Crescent CY Hsieh <crescentcy.hsieh@moxa.com>
>> Cc: Jiri Slaby <jirislaby@kernel.org>
>> Cc: Lukas Wunner <lukas@wunner.de>
>> Cc: Lino Sanfilippo <l.sanfilippo@kunbus.com>
>> Cc: Hugo Villeneuve <hugo@hugovil.com>
>> To: linux-serial@vger.kernel.org
>> To: linux-arm-kernel@lists.infradead.org
> 
> "To" is not supported here, IMO.

OK.

> When you fix that:
> Reviewed-by: Jiri Slaby <jirislaby@kernel.org>

I will create a version 3.

[...]

Regards
Christoph