From: Jiri Slaby <jirislaby@kernel.org>
To: Thomas Zimmermann <tzimmermann@suse.de>,
Geert Uytterhoeven <geert@linux-m68k.org>
Cc: deller@gmx.de, gregkh@linuxfoundation.org, simona@ffwll.ch,
sam@ravnborg.org, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH 04/10] lib/fonts: Clean up Makefile
Date: Wed, 1 Apr 2026 10:58:27 +0200 [thread overview]
Message-ID: <7eaf55fd-1ec9-4c30-877f-12961e8f9532@kernel.org> (raw)
In-Reply-To: <a2b5aa02-2566-409f-960d-4ecb1419cbd5@suse.de>
On 01. 04. 26, 9:58, Thomas Zimmermann wrote:
>>> -font-objs-$(CONFIG_FONT_SUN8x16) += font_sun8x16.o
>>> -font-objs-$(CONFIG_FONT_SUN12x22) += font_sun12x22.o
>>> -font-objs-$(CONFIG_FONT_8x8) += font_8x8.o
>>> -font-objs-$(CONFIG_FONT_8x16) += font_8x16.o
>>> -font-objs-$(CONFIG_FONT_6x11) += font_6x11.o
>>> -font-objs-$(CONFIG_FONT_7x14) += font_7x14.o
>>> -font-objs-$(CONFIG_FONT_10x18) += font_10x18.o
>>> -font-objs-$(CONFIG_FONT_PEARL_8x8) += font_pearl_8x8.o
>>> -font-objs-$(CONFIG_FONT_ACORN_8x8) += font_acorn_8x8.o
>>> -font-objs-$(CONFIG_FONT_MINI_4x6) += font_mini_4x6.o
>>> -font-objs-$(CONFIG_FONT_6x10) += font_6x10.o
>>> -font-objs-$(CONFIG_FONT_TER10x18) += font_ter10x18.o
>>> -font-objs-$(CONFIG_FONT_TER16x32) += font_ter16x32.o
>>> -font-objs-$(CONFIG_FONT_6x8) += font_6x8.o
>>> +# Built-in fonts
>>> +font-$(CONFIG_FONT_10x18) += font_10x18.o
>>> +font-$(CONFIG_FONT_6x10) += font_6x10.o
>>> +font-$(CONFIG_FONT_6x11) += font_6x11.o
>>> +font-$(CONFIG_FONT_6x8) += font_6x8.o
>>> +font-$(CONFIG_FONT_7x14) += font_7x14.o
>>> +font-$(CONFIG_FONT_8x16) += font_8x16.o
>>> +font-$(CONFIG_FONT_8x8) += font_8x8.o
>> Please sort the anonymous entries by increasing font size.
>
> Makes sense. I'll also leave a comment on the sorting order.
>>> +font-$(CONFIG_FONT_SUN12x22) += font_sun12x22.o
>>> +font-$(CONFIG_FONT_SUN8x16) += font_sun8x16.o
I'd sort even the non-anonymous ^^.
thanks,
--
js
suse labs
next prev parent reply other threads:[~2026-04-01 8:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 12:49 [PATCH 00/10] fbcon,fonts: Refactor framebuffer console rotation Thomas Zimmermann
2026-03-27 12:49 ` [PATCH 01/10] fbcon: Avoid OOB font access if console rotation fails Thomas Zimmermann
2026-03-27 12:49 ` [PATCH 02/10] vt: Implement helpers for struct vc_font in source file Thomas Zimmermann
2026-03-30 15:35 ` Greg KH
2026-03-27 12:49 ` [PATCH 03/10] lib/fonts: Provide helpers for calculating glyph pitch and size Thomas Zimmermann
2026-03-27 12:49 ` [PATCH 04/10] lib/fonts: Clean up Makefile Thomas Zimmermann
2026-04-01 7:48 ` Geert Uytterhoeven
2026-04-01 7:58 ` Thomas Zimmermann
2026-04-01 8:58 ` Jiri Slaby [this message]
2026-04-01 9:09 ` Thomas Zimmermann
2026-03-27 12:49 ` [PATCH 05/10] lib/fonts: Implement glyph rotation Thomas Zimmermann
2026-03-27 12:49 ` [PATCH 06/10] lib/fonts: Refactor glyph-pattern helpers Thomas Zimmermann
2026-03-27 12:49 ` [PATCH 07/10] lib/fonts: Refactor glyph-rotation helpers Thomas Zimmermann
2026-03-27 12:49 ` [PATCH 08/10] lib/fonts: Implement font rotation Thomas Zimmermann
2026-03-27 12:49 ` [PATCH 09/10] fbcon: Fill cursor mask in helper function Thomas Zimmermann
2026-03-27 12:49 ` [PATCH 10/10] fbcon: Put font-rotation state into separate struct Thomas Zimmermann
2026-03-31 15:08 ` [PATCH 00/10] fbcon,fonts: Refactor framebuffer console rotation Helge Deller
2026-03-31 15:29 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7eaf55fd-1ec9-4c30-877f-12961e8f9532@kernel.org \
--to=jirislaby@kernel.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox