linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ian W MORRISON <ianwmorrison@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>,
	Johan Hovold <johan@kernel.org>,
	"Gustavo F. Padovan" <gustavo@padovan.org>,
	Johan Hedberg <johan.hedberg@gmail.com>,
	"bluez mailin list (linux-bluetooth@vger.kernel.org)"
	<linux-bluetooth@vger.kernel.org>,
	hdegoede@redhat.com, frederic.danis.oss@gmail.com,
	robh@kernel.org, sre@kernel.org,
	Loic Poulain <loic.poulain@gmail.com>,
	lukas@wunner.de, linux-serial@vger.kernel.org,
	linux-acpi@vger.kernel.org, rafael@kernel.org,
	Greg Kroah-Hartman <greg@kroah.com>
Subject: [PATCH v2 1/2] serdev: Update drivers/tty/serdev/Kconfig for ACPI serdev support
Date: Sun, 8 Oct 2017 14:20:07 +1100	[thread overview]
Message-ID: <82b477ef-757a-c953-45e8-fd68b28286e5@gmail.com> (raw)

ACPI and DT both need SERIAL_DEV_CTRL_TTYPORT to work properly since SERIAL_DEV_CTRL_TTYPORT is the only controller implemented for serdev. This is only possible if serdev support is compiled in as the code hooks into TTY. Otherwise PM will silently break as the corresponding platform devices would no longer be registered and as the tty class device is also gone and hciattach (btattach) will also fail.

This patch set addresses this by making BT_HCIUART_BCM dependent on SERIAL_DEV_CTRL_TTYPORT which in turn is dependent on SERIAL_DEV_BUS and ensures that if SERIAL_DEV_BUS is selected is the code is build it.

Signed-off-by: Ian W MORRISON <ianwmorrison@gmail.com>
---
 drivers/tty/serdev/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serdev/Kconfig b/drivers/tty/serdev/Kconfig
index cdc6b820cf93..1144f4db5087 100644
--- a/drivers/tty/serdev/Kconfig
+++ b/drivers/tty/serdev/Kconfig
@@ -2,7 +2,7 @@
 # Serial bus device driver configuration
 #
 menuconfig SERIAL_DEV_BUS
-	tristate "Serial device bus"
+	bool "Serial device bus"
 	help
 	  Core support for devices connected via a serial port.
 
@@ -11,6 +11,6 @@ if SERIAL_DEV_BUS
 config SERIAL_DEV_CTRL_TTYPORT
 	bool "Serial device TTY port controller"
 	depends on TTY
-	depends on SERIAL_DEV_BUS != m
+	depends on SERIAL_DEV_BUS
 
 endif
-- 
2.11.0

             reply	other threads:[~2017-10-08  3:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-08  3:20 Ian W MORRISON [this message]
2017-10-08  7:26 ` [PATCH v2 1/2] serdev: Update drivers/tty/serdev/Kconfig for ACPI serdev support Greg KH
     [not found]   ` <20171008072655.GA3444-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-10-09  0:43     ` Ian W MORRISON
     [not found] ` <82b477ef-757a-c953-45e8-fd68b28286e5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-10-09  0:43   ` [PATCH v3 " Ian W MORRISON
2017-10-09  7:54     ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82b477ef-757a-c953-45e8-fd68b28286e5@gmail.com \
    --to=ianwmorrison@gmail.com \
    --cc=frederic.danis.oss@gmail.com \
    --cc=greg@kroah.com \
    --cc=gustavo@padovan.org \
    --cc=hdegoede@redhat.com \
    --cc=johan.hedberg@gmail.com \
    --cc=johan@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=loic.poulain@gmail.com \
    --cc=lukas@wunner.de \
    --cc=marcel@holtmann.org \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).