From: Jiri Slaby <jirislaby@kernel.org>
To: Ricardo Ribalda <ribalda@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Corbet <corbet@lwn.net>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v1 1/1] earlycon: Let users set the clock frequency
Date: Thu, 24 Nov 2022 06:58:20 +0100 [thread overview]
Message-ID: <83146e51-2b63-c2eb-65e3-8122921a89ea@kernel.org> (raw)
In-Reply-To: <20221123-serial-clk-v1-1-1f0554a46ad1@chromium.org>
Hi,
On 24. 11. 22, 0:29, Ricardo Ribalda wrote:
> Some platforms, namely AMD Picasso, use non standard uart clocks (48M),
> witch makes it impossible to use with earlycon.
>
> Let the user select its own frequency.
...
> --- a/drivers/tty/serial/earlycon.c
> +++ b/drivers/tty/serial/earlycon.c
> @@ -120,7 +120,11 @@ static int __init parse_options(struct earlycon_device *device, char *options)
> }
>
> if (options) {
> + char *uartclk;
> device->baud = simple_strtoul(options, NULL, 0);
> + uartclk = strchr(options, ',');
> + if (uartclk)
> + port->uartclk = simple_strtoull(uartclk + 1, NULL, 0);
uartclk is uint. So why does it make sense to do ull parsing?
thanks,
--
js
suse labs
prev parent reply other threads:[~2022-11-24 5:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 23:29 [PATCH v1 0/1] earlycon: Let users set the clock frequency Ricardo Ribalda
2022-11-23 23:29 ` [PATCH v1 1/1] " Ricardo Ribalda
2022-11-24 5:58 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83146e51-2b63-c2eb-65e3-8122921a89ea@kernel.org \
--to=jirislaby@kernel.org \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=ribalda@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).