From: John Ogness <john.ogness@linutronix.de>
To: Sean Anderson <sean.anderson@linux.dev>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-serial@vger.kernel.org
Cc: Manikanta Guntupalli <manikanta.guntupalli@amd.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Michal Simek <michal.simek@amd.com>,
Thomas Gleixner <tglx@linutronix.de>,
Sean Anderson <sean.anderson@linux.dev>,
stable@vger.kernel.org
Subject: Re: [PATCH] tty: xilinx_uartps: split sysrq handling
Date: Sat, 11 Jan 2025 09:16:49 +0106 [thread overview]
Message-ID: <841px9u5x2.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <20250110213822.2107462-1-sean.anderson@linux.dev>
On 2025-01-10, Sean Anderson <sean.anderson@linux.dev> wrote:
> Fix this by splitting sysrq handling into two parts. We use the prepare
> helper under the port lock and defer handling until we release the lock.
Note that this fix is only necessary because this console driver is
using the legacy console API. For the NBCON API it is allowed to call
printk() while holding the port lock.
But since code already exists to allow deferring the sysrq execution
until the port lock is not held, this patch is probably a good idea
anyway because it can reduce port lock contention. AFAIK there are no
sysrq actions that require port lock synchronization.
Acked-by: John Ogness <john.ogness@linutronix.de>
prev parent reply other threads:[~2025-01-11 8:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-10 21:38 [PATCH] tty: xilinx_uartps: split sysrq handling Sean Anderson
2025-01-11 8:10 ` John Ogness [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=841px9u5x2.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=manikanta.guntupalli@amd.com \
--cc=michal.simek@amd.com \
--cc=sean.anderson@linux.dev \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox