From: John Ogness <john.ogness@linutronix.de>
To: Andy Shevchenko <andy.shevchenko@gmail.com>, adamsimonelli@gmail.com
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Jiri Slaby <jirislaby@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Petr Mladek <pmladek@suse.com>
Subject: Re: [PATCH v6 1/3] ttynull: Always initialize console index to -1
Date: Tue, 04 Mar 2025 09:59:41 +0106 [thread overview]
Message-ID: <84tt89qiqy.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <CAHp75VdYOWkDj0VTa5H9V7jV=Sr5O4=L-1TN55MJU=ownOAJ1Q@mail.gmail.com>
On 2025-03-04, Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> In general we do not accept empty commit messages (yes, it was done in
> the past and in some exceptional cases, but should be taken as a very
> bad practice).
It would also be nice if the commit message explained _why_ the change
is done and how it affects the driver behavior as opposed to previously.
John Ogness
next prev parent reply other threads:[~2025-03-04 8:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 3:54 [PATCH v6 0/3] Optionally allow ttynull to be selected as a default console adamsimonelli
2025-03-04 3:54 ` [PATCH v6 1/3] ttynull: Always initialize console index to -1 adamsimonelli
2025-03-04 6:01 ` Andy Shevchenko
2025-03-04 8:53 ` John Ogness [this message]
2025-03-04 3:54 ` [PATCH v6 2/3] ttynull: Add an option to allow ttynull to be used as a console device adamsimonelli
2025-03-04 6:07 ` Andy Shevchenko
2025-03-04 3:54 ` [PATCH v6 3/3] tty: Change order of ttynull to be linked sooner if enabled as a console adamsimonelli
2025-03-04 6:51 ` Andy Shevchenko
2025-03-05 2:06 ` Adam Simonelli
2025-03-05 4:15 ` Adam Simonelli
2025-03-05 18:52 ` Andy Shevchenko
2025-03-06 4:22 ` Adam Simonelli
2025-03-06 7:10 ` Andy Shevchenko
2025-03-12 13:42 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84tt89qiqy.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=adamsimonelli@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox