From: John Ogness <john.ogness@linutronix.de>
To: Luis Chamberlain <mcgrof@kernel.org>,
Yoann Congal <yoann.congal@smile.fr>,
Josh Triplett <josh@joshtriplett.org>,
Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kbuild@vger.kernel.org,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>,
"Dave Hansen" <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Willem de Bruijn" <willemdebruijn.kernel@gmail.com>,
"Matthew Wilcox" <willy@infradead.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"Darren Hart" <dvhart@infradead.org>,
"Davidlohr Bueso" <dave@stgolabs.net>,
"André Almeida" <andrealmeid@igalia.com>,
"Masahiro Yamada" <masahiroy@kernel.org>
Subject: Re: [PATCH v2] printk: Remove redundant CONFIG_BASE_SMALL
Date: Wed, 31 Jan 2024 16:53:32 +0106 [thread overview]
Message-ID: <871q9xzeqz.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <ZbfLl6PR_qxxreeX@bombadil.infradead.org>
On 2024-01-29, Luis Chamberlain <mcgrof@kernel.org> wrote:
> You should mention the one case which this patch fixes is:
>
>> CONFIG_BASE_SMALL was used that way in init/Kconfig:
>> config LOG_CPU_MAX_BUF_SHIFT
>> default 12 if !BASE_SMALL
>> default 0 if BASE_SMALL
>
> You should then mention this has been using 12 for a long time now
> for BASE_SMALL, and so this patch is a functional fix for those
> who used BASE_SMALL and wanted a smaller printk buffer contribtion per
> cpu. The contribution was only per CPU, and since BASE_SMALL systems
> likely don't have many CPUs the impact of this was relatively small,
> 4 KiB per CPU. This patch fixes that back down to 0 KiB per CPU.
For printk this will mean that BASE_SMALL systems were probably
previously allocating/using the dynamic ringbuffer and now they will
just continue to use the static ringbuffer. Which is fine and saves
memory (as it should).
Reviewed-by: John Ogness <john.ogness@linutronix.de>
prev parent reply other threads:[~2024-01-31 15:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-27 22:00 [PATCH v2] printk: Remove redundant CONFIG_BASE_SMALL Yoann Congal
2024-01-29 11:28 ` Jiri Slaby
2024-01-29 12:56 ` Yoann Congal
2024-01-29 16:00 ` Luis Chamberlain
2024-01-31 14:34 ` Masahiro Yamada
2024-01-31 15:47 ` John Ogness [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871q9xzeqz.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=andrealmeid@igalia.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=dave@stgolabs.net \
--cc=dvhart@infradead.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jirislaby@kernel.org \
--cc=josh@joshtriplett.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mcgrof@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=tglx@linutronix.de \
--cc=willemdebruijn.kernel@gmail.com \
--cc=willy@infradead.org \
--cc=x86@kernel.org \
--cc=yoann.congal@smile.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox