From mboxrd@z Thu Jan 1 00:00:00 1970 From: Baruch Siach Subject: Re: [PATCH] tty/serial: digicolor: Fix digicolor-usart already registered warning Date: Sat, 01 Jun 2019 23:21:28 +0300 Message-ID: <8736ktoy47.fsf@tarshish> References: <20190531133733.16243-1-wangkefeng.wang@huawei.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-reply-to: <20190531133733.16243-1-wangkefeng.wang@huawei.com> Sender: linux-kernel-owner@vger.kernel.org To: Kefeng Wang Cc: Greg Kroah-Hartman , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Hulk Robot List-Id: linux-serial@vger.kernel.org Hi Kefeng, On Fri, May 31 2019, Kefeng Wang wrote: > When modprobe/rmmod/modprobe module, if platform_driver_register() fails, > the kernel complained, > > proc_dir_entry 'driver/digicolor-usart' already registered > WARNING: CPU: 1 PID: 5636 at fs/proc/generic.c:360 proc_register+0x19d/0x270 > > Fix this by adding uart_unregister_driver() when platform_driver_register() fails. > > Reported-by: Hulk Robot > Signed-off-by: Kefeng Wang Acked-by: Baruch Siach Thanks, baruch > --- > drivers/tty/serial/digicolor-usart.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/digicolor-usart.c b/drivers/tty/serial/digicolor-usart.c > index f460cca139e2..13ac36e2da4f 100644 > --- a/drivers/tty/serial/digicolor-usart.c > +++ b/drivers/tty/serial/digicolor-usart.c > @@ -541,7 +541,11 @@ static int __init digicolor_uart_init(void) > if (ret) > return ret; > > - return platform_driver_register(&digicolor_uart_platform); > + ret = platform_driver_register(&digicolor_uart_platform); > + if (ret) > + uart_unregister_driver(&digicolor_uart); > + > + return ret; > } > module_init(digicolor_uart_init); -- http://baruch.siach.name/blog/ ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -