From: Sergey Organov <sorganov@gmail.com>
To: Thorsten Leemhuis <regressions@leemhuis.info>
Cc: "Stefan Wahren" <stefan.wahren@i2se.com>,
"Linux regressions mailing list" <regressions@lists.linux.dev>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Stefan Wahren" <stefan.wahren@chargebyte.com>,
linux-serial@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Shawn Guo" <shawnguo@kernel.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Tomasz Moń" <tomasz.mon@camlingroup.com>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>
Subject: Re: Regression: serial: imx: overrun errors on debug UART
Date: Wed, 24 May 2023 16:45:10 +0300 [thread overview]
Message-ID: <87a5xtyhax.fsf@osv.gnss.ru> (raw)
In-Reply-To: <80207a43-6047-4493-da5d-8bd87ef74551@leemhuis.info> (Thorsten Leemhuis's message of "Wed, 24 May 2023 12:48:51 +0200")
Thorsten Leemhuis <regressions@leemhuis.info> writes:
> On 23.05.23 21:44, Sergey Organov wrote:
>> "Linux regression tracking (Thorsten Leemhuis)"
>> <regressions@leemhuis.info> writes:
>>
>>> Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting
>>> for once, to make this easily accessible to everyone.
>>>
>>> Stefan, was this regression ever solved? It doesn't look like it, but
>>> maybe I'm missing something.
>>>
>>> If it wasn't solved: what needs to be done to get this rolling again?
>>
>> Not Stefan,
>
> Thx to both you and Stefan for the update.
>
>> but as far as I can tell, the problem is that on Stefan's
>> build the kernel has rather large periods of interrupts being disabled,
>> so any attempt to decrease IRQs frequency from UART by raising FIFO IRQ
>> threshold causes "regression" that manifests itself as missing
>> characters on receive. I'm not sure if it's tuning FIFO level that is in
>> fact a regression in this case.
>
> Not totally sure, but I guess Linus stance in this case would be along
> the lines of "commit 7a637784d517 made an existing issue worse; either
> the people involved in it fix it, or we revert that commit[1], as it's
> causing a regression". At least we *iirc* had situations he handled like
> that.
From Stefan's investigations it follows that the kernel has interrupts
disabled for about 2.5 milliseconds! If that's an acceptable value for
Linux kernel, then the commit in question is a regression. If not, and
in my opinion that's too high a number, then it's not a regression at
all, but rather a manifestation of a problem (bug?) elsewhere.
>
> [1] of course unless a revert would cause regressions for others --
> which i guess might be the case here, as that was added in 5.18 already.
> So let's not bring Linus in.
>
>> Solving this would need to identify the cause of interrupts being
>> disabled for prolonged times, and nobody volunteered to investigate this
>> further.
>
> Well, Stefan kind of did to do so in his spare time, but asked for
> "clear instructions to investigate this further". Could you maybe
> provide those? If not: who could?
There should be somebody who is familiar with methods to isolate the
victim of abnormal interrupts latencies, but I'm not the one, sorry.
Thanks,
-- Sergey Organov
next prev parent reply other threads:[~2023-05-24 13:45 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 8:57 Regression: serial: imx: overrun errors on debug UART Stefan Wahren
2023-03-24 10:12 ` Linux regression tracking #adding (Thorsten Leemhuis)
2023-03-24 11:47 ` Ilpo Järvinen
2023-03-24 12:26 ` Francesco Dolcini
2023-03-24 12:35 ` Ilpo Järvinen
2023-03-24 12:49 ` Stefan Wahren
2023-03-24 13:06 ` Francesco Dolcini
2023-03-24 12:57 ` Fabio Estevam
2023-03-24 13:37 ` Uwe Kleine-König
2023-03-24 14:19 ` Stefan Wahren
2023-03-24 14:39 ` Uwe Kleine-König
2023-03-24 21:57 ` Sergey Organov
2023-03-24 15:00 ` Stefan Wahren
2023-03-25 11:31 ` Stefan Wahren
2023-03-25 12:23 ` Fabio Estevam
2023-03-25 15:11 ` Uwe Kleine-König
2023-03-25 17:05 ` Stefan Wahren
2023-03-25 19:00 ` Sergey Organov
2023-03-26 18:21 ` Francesco Dolcini
2023-03-27 8:07 ` Tomasz Moń
2023-03-25 18:30 ` Sergey Organov
2023-03-27 14:42 ` Stefan Wahren
2023-03-27 15:11 ` Sergey Organov
2023-03-27 15:30 ` Russell King (Oracle)
2023-04-16 13:43 ` Stefan Wahren
2023-04-17 16:50 ` Sergey Organov
2023-04-17 18:40 ` Stefan Wahren
2023-04-18 16:16 ` Stefan Wahren
2023-05-22 9:25 ` Linux regression tracking (Thorsten Leemhuis)
2023-05-23 15:12 ` Stefan Wahren
2023-05-23 19:44 ` Sergey Organov
2023-05-24 10:48 ` Thorsten Leemhuis
2023-05-24 12:41 ` Uwe Kleine-König
2023-05-24 13:45 ` Sergey Organov [this message]
2023-05-24 13:07 ` Stefan Wahren
2023-06-20 14:47 ` Linux regression tracking (Thorsten Leemhuis)
2023-06-20 14:59 ` Greg Kroah-Hartman
2023-06-20 15:34 ` Sergey Organov
2023-06-20 16:30 ` Stefan Wahren
2023-06-20 16:40 ` Lucas Stach
2023-06-20 16:55 ` Stefan Wahren
2023-06-20 19:27 ` Uwe Kleine-König
2023-06-21 8:43 ` Greg Kroah-Hartman
2023-06-21 6:23 ` Stefan Wahren
2023-06-21 13:42 ` Linux regression tracking (Thorsten Leemhuis)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5xtyhax.fsf@osv.gnss.ru \
--to=sorganov@gmail.com \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-serial@vger.kernel.org \
--cc=regressions@leemhuis.info \
--cc=regressions@lists.linux.dev \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=stefan.wahren@chargebyte.com \
--cc=stefan.wahren@i2se.com \
--cc=tomasz.mon@camlingroup.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).