From: John Ogness <john.ogness@linutronix.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Andreas Schwab <schwab@linux-m68k.org>
Cc: linux-m68k@vger.kernel.org, Petr Mladek <pmladek@suse.com>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>
Subject: Re: [PATCH] m68k: nfcon: don't call console_is_registered in nfcon_device
Date: Thu, 20 Aug 2026 12:22:46 +0206 [thread overview]
Message-ID: <87fr099jw1.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <CAMuHMdU4C+W6Tpsn3Vr_kqmuU2Vzg7ExXhspmB5qNWMZ3Wnfeg@mail.gmail.com>
On 2026-08-17, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Sat, 15 Aug 2026 at 09:33, Andreas Schwab <schwab@linux-m68k.org> wrote:
>> Since 7c2af0f634f1 ("tty: tty_io: use console_list_lock for list
>> synchronization") show_cons_active calls the device method under the
>> console_list_lock, but console_is_registered tries to acquire
>> console_list_lock as well, causing a deadlock. It should not be necessary
>> to check console_is_registered here since the function should not be
>> called in the fist place when the console is not registered.
>
> Nice catch!
>
>> Fixes: 7c2af0f634f1 ("tty: tty_io: use console_list_lock for list synchronization")
>> Signed-off-by: Andreas Schwab <schwab@linux-m68k.org>
>
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
FWIW:
Reviewed-by: John Ogness <john.ogness@linutronix.de>
next prev parent reply other threads:[~2026-08-20 10:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87ecfzsv6h.fsf@igel.home>
2026-08-17 9:26 ` [PATCH] m68k: nfcon: don't call console_is_registered in nfcon_device Geert Uytterhoeven
2026-08-20 10:16 ` John Ogness [this message]
2026-08-20 12:57 ` Petr Mladek
2026-08-20 13:38 ` John Ogness
2026-08-20 15:57 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fr099jw1.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=geert@linux-m68k.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox