From: Jonathan Corbet <corbet@lwn.net>
To: Karl Mehltretter <kmehltretter@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>
Cc: "Karl Mehltretter" <kmehltretter@gmail.com>,
linux-serial@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Shuah Khan" <skhan@linuxfoundation.org>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: Re: [PATCH] Documentation: rs485: Pull uart_get_rs485_mode() from serial_core.c
Date: Mon, 07 Sep 2026 09:52:27 -0600 [thread overview]
Message-ID: <87ik4hvz2c.fsf@trenco.lwn.net> (raw)
In-Reply-To: <20260905083648.39026-1-kmehltretter@gmail.com>
Karl Mehltretter <kmehltretter@gmail.com> writes:
> serial-rs485.rst asks include/uapi/linux/serial.h for both struct
> serial_rs485 and uart_get_rs485_mode(). The function and its kernel-doc
> comment live in drivers/tty/serial/serial_core.c, so the directive has
> never rendered it and the section shows only the structure.
>
> Add a second directive for serial_core.c.
>
> Fixes: 0f4648a1a6d3 ("Documentation: rs485: Mention uart_get_rs485_mode()")
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
> ---
> Documentation/driver-api/serial/serial-rs485.rst | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/driver-api/serial/serial-rs485.rst b/Documentation/driver-api/serial/serial-rs485.rst
> index f53043d21071..98d8d83718c6 100644
> --- a/Documentation/driver-api/serial/serial-rs485.rst
> +++ b/Documentation/driver-api/serial/serial-rs485.rst
> @@ -50,7 +50,10 @@ RS485 Serial Communications
> matching to the current configuration.
>
> .. kernel-doc:: include/uapi/linux/serial.h
> - :identifiers: serial_rs485 uart_get_rs485_mode
> + :identifiers: serial_rs485
> +
> +.. kernel-doc:: drivers/tty/serial/serial_core.c
> + :identifiers: uart_get_rs485_mode
Applied, thanks.
jon
prev parent reply other threads:[~2026-09-07 15:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-05 8:36 [PATCH] Documentation: rs485: Pull uart_get_rs485_mode() from serial_core.c Karl Mehltretter
2026-09-05 8:39 ` sashiko-bot
2026-09-05 21:46 ` Randy Dunlap
2026-09-07 15:52 ` Jonathan Corbet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ik4hvz2c.fsf@trenco.lwn.net \
--to=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=kmehltretter@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox