From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Jarzmik Subject: Re: [PATCH v6 RESEND] serial: rewrite pxa2xx-uart to use 8250_core Date: Thu, 06 Oct 2016 08:25:35 +0200 Message-ID: <87shsa804g.fsf@belgarion.home> References: <1474993396-525-1-git-send-email-robert.jarzmik@free.fr> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1474993396-525-1-git-send-email-robert.jarzmik@free.fr> (Robert Jarzmik's message of "Tue, 27 Sep 2016 18:23:16 +0200") Sender: linux-kernel-owner@vger.kernel.org To: Greg Kroah-Hartman Cc: Jiri Slaby , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Sergey Yanovich , Heikki Krogerus , James Cameron , Russell King List-Id: linux-serial@vger.kernel.org Robert Jarzmik writes: > From: Sergey Yanovich > > pxa2xx-uart was a separate uart platform driver. It was declaring > the same device names and numbers as 8250 driver. As a result, > it was impossible to use 8250 driver on PXA SoCs. > > Upon closer examination pxa2xx-uart turned out to be a clone of > 8250_core driver. > > Workaround for Erratum #19 according to Marvel(R) PXA270M Processor > Specification Update (April 19, 2010) is dropped. 8250_core reads > from FIFO immediately after checking DR bit in LSR. > > The patch leaves the original SERIAL_PXA driver around. The original > driver is just marked DEPRECATED in Kconfig and C source. When > the original driver is considered safe to remove, no changes > to SERIAL_8250 will be necessary. > > Compiling SERIAL_8250_CONSOLE and SERIAL_PXA_CONSOLE even without > SERIAL_8250_PXA breaks console for SERIAL_PXA. For this reasons, the new > and the original drivers are made mutually exclusive. > > Signed-off-by: Sergei Ianovich > CC: Heikki Krogerus > CC: James Cameron > CC: Greg Kroah-Hartman > CC: Robert Jarzmik > CC: Russell King > Reviewed-by: Heikki Krogerus > [rebased on v4.8] > Tested-by: Robert Jarzmik > Signed-off-by: Robert Jarzmik Greg, can you take that into you tty tree please ? Cheers. -- Robert