From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory CLEMENT Subject: Re: [PATCH 03/16] serial: mvebu-uart: use driver name when requesting an interrupt Date: Fri, 06 Oct 2017 14:19:37 +0200 Message-ID: <87tvzcfoyu.fsf@free-electrons.com> References: <20171006101344.15590-1-miquel.raynal@free-electrons.com> <20171006101344.15590-4-miquel.raynal@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20171006101344.15590-4-miquel.raynal-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> (Miquel Raynal's message of "Fri, 6 Oct 2017 12:13:31 +0200") Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Miquel Raynal Cc: Greg Kroah-Hartman , Linus Walleij , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Jiri Slaby , Catalin Marinas , Will Deacon , Thomas Petazzoni , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Yehuda Yitschak , Antoine Tenart , Nadav Haklai , linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Wilson Ding , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-serial@vger.kernel.org Hi Miquel, On ven., oct. 06 2017, Miquel Raynal wrote: > From: Yehuda Yitschak > > Use the driver name when requesting an interrupt for consistency. > > Avoids possible confusion with DW8250 driver interrupt names in > /proc/interrupts. > > Signed-off-by: Yehuda Yitschak > Signed-off-by: Miquel Raynal Reviewed-by: Gregory CLEMENT Thanks, Gregory > --- > drivers/tty/serial/mvebu-uart.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/tty/serial/mvebu-uart.c b/drivers/tty/serial/mvebu-uart.c > index 45b57c294d13..7e0a3e9fee15 100644 > --- a/drivers/tty/serial/mvebu-uart.c > +++ b/drivers/tty/serial/mvebu-uart.c > @@ -90,6 +90,7 @@ > #define MVEBU_NR_UARTS 1 > > #define MVEBU_UART_TYPE "mvebu-uart" > +#define DRIVER_NAME "mvebu_serial" > > static struct uart_port mvebu_uart_ports[MVEBU_NR_UARTS]; > > @@ -287,8 +288,8 @@ static int mvebu_uart_startup(struct uart_port *port) > udelay(1); > writel(CTRL_RX_INT, port->membase + UART_CTRL); > > - ret = request_irq(port->irq, mvebu_uart_isr, port->irqflags, "serial", > - port); > + ret = request_irq(port->irq, mvebu_uart_isr, port->irqflags, > + DRIVER_NAME, port); > if (ret) { > dev_err(port->dev, "failed to request irq\n"); > return ret; > @@ -538,7 +539,7 @@ console_initcall(mvebu_uart_console_init); > > static struct uart_driver mvebu_uart_driver = { > .owner = THIS_MODULE, > - .driver_name = "mvebu_serial", > + .driver_name = DRIVER_NAME, > .dev_name = "ttyMV", > .nr = MVEBU_NR_UARTS, > #ifdef CONFIG_SERIAL_MVEBU_CONSOLE > -- > 2.11.0 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html