From: Li Chen <me@linux.beauty>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Li Chen" <lchen@ambarella.com>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Sumit Semwal" <sumit.semwal@linaro.org>,
"Christian König" <christian.koenig@amd.com>,
"open list" <linux-kernel@vger.kernel.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
"moderated list:ARM/Ambarella SoC support"
<linux-arm-kernel@lists.infradead.org>,
"open list:DMA BUFFER SHARING FRAMEWORK"
<linux-media@vger.kernel.org>,
"open list:DMA BUFFER SHARING FRAMEWORK"
<dri-devel@lists.freedesktop.org>,
"moderated list:DMA BUFFER SHARING FRAMEWORK"
<linaro-mm-sig@lists.linaro.org>
Subject: Re: [PATCH 10/15] serial: ambarella: add support for Ambarella uart_port
Date: Wed, 25 Jan 2023 18:01:25 +0800 [thread overview]
Message-ID: <87v8kvgcga.wl-me@linux.beauty> (raw)
In-Reply-To: <Y85YncUCtRyVnpvt@kroah.com>
On Mon, 23 Jan 2023 17:51:25 +0800,
Hi Greg,
Sorry for my late reply.
Greg Kroah-Hartman wrote:
>
> On Mon, Jan 23, 2023 at 03:32:25PM +0800, Li Chen wrote:
> > This driver add support for Ambarella's uart, which
> > can be used for console and etc.
> >
> > Signed-off-by: Li Chen <lchen@ambarella.com>
> > Change-Id: Ie68af7ad2187e21853e58d52cd97fd7145303730
> > ---
> > MAINTAINERS | 1 +
> > drivers/tty/serial/Kconfig | 16 +
> > drivers/tty/serial/Makefile | 1 +
> > drivers/tty/serial/ambarella_uart.c | 1581 +++++++++++++++++++++++++++
> > drivers/tty/serial/ambarella_uart.h | 120 ++
>
> Why do you need a .h file for a single .c file? They should all be in
> one file please.
Ok, I will combine them into single source file.
> Also, no change-id, you know this...
>
> thanks,
>
> greg k-h
Regards,
Li
prev parent reply other threads:[~2023-01-25 10:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 7:32 [PATCH 00/15] Ambarella S6LM SoC bring-up Li Chen
[not found] ` <20230123073305.149940-10-lchen@ambarella.com>
2023-01-23 8:11 ` [PATCH 09/15] dt-bindings: serial: add support for Ambarella Krzysztof Kozlowski
2023-01-25 9:54 ` Li Chen
2023-01-25 9:56 ` Krzysztof Kozlowski
2023-01-28 9:22 ` Li Chen
2023-01-23 8:39 ` [PATCH 00/15] Ambarella S6LM SoC bring-up Arnd Bergmann
2023-01-24 2:08 ` Bagas Sanjaya
[not found] ` <20230123073305.149940-11-lchen@ambarella.com>
2023-01-23 9:50 ` [PATCH 10/15] serial: ambarella: add support for Ambarella uart_port Greg Kroah-Hartman
2023-01-23 9:51 ` Greg Kroah-Hartman
2023-01-25 10:01 ` Li Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8kvgcga.wl-me@linux.beauty \
--to=me@linux.beauty \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=lchen@ambarella.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).