From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Jarzmik Subject: Re: [PATCH v4 1/2] serial: rewrite pxa2xx-uart to use 8250_core Date: Sat, 19 Dec 2015 14:26:28 +0100 Message-ID: <87y4cqfu2j.fsf@belgarion.home> References: <1387309071-22382-1-git-send-email-ynvich@gmail.com> <1449700088-28076-1-git-send-email-ynvich@gmail.com> <1449700088-28076-2-git-send-email-ynvich@gmail.com> <8737uyhaji.fsf@belgarion.home> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <8737uyhaji.fsf@belgarion.home> (Robert Jarzmik's message of "Sat, 19 Dec 2015 13:45:21 +0100") Sender: linux-kernel-owner@vger.kernel.org To: Sergei Ianovich Cc: linux-kernel@vger.kernel.org, Kevin Hilman , Arnd Bergmann , "moderated list:ARM PORT" , "open list:SERIAL DRIVERS" List-Id: linux-serial@vger.kernel.org Robert Jarzmik writes: > Sergei Ianovich writes: > >> pxa2xx-uart was a separate uart platform driver. It was declaring >> the same device names and numbers as 8250 driver. As a result, >> it was impossible to use 8250 driver on PXA SoCs. >> >> Upon closer examination pxa2xx-uart turned out to be a clone of >> 8250_core driver. >> >> Workaround for Erratum #19 according to Marvel(R) PXA270M Processor >> Specification Update (April 19, 2010) is dropped. 8250_core reads >> from FIFO immediately after checking DR bit in LSR. >> >> Signed-off-by: Sergei Ianovich >> Reviewed-by: Heikki Krogerus >> Reviewed-by: James Cameron >> Acked-by: Greg Kroah-Hartman > Tested-by: Robert Jarzmik Shrunk the list, the following is rather mach-pxa specific. Actually there is a small glitch ... Have a look at arch/arm/mach-pxa/viper.c, line 490: #ifndef CONFIG_SERIAL_PXA ... But that can be handled in an subsequent patch to keep your acks and reviews. Cheers. -- Robert