Re: Change to serial_core.c .... causing my serial driver problem Help Request

[vcgandhi1@aol.com]

Guennadi,

I think the issue is when the serial port is embedded and not connected 
through the bus. So I am talking about the drivers in the 
kernel/drivers/serial directory. A few of them use suspend and resume 
and I think they may not be compatible with your change. 

Do you know if you anybody tested any serial ports that are located in 
that directory and use  the suspend and resume calls. Ports not 
connected through the pci  bus.

Vipul



-----Original Message-----
From: vcgandhi1@aol.com
To: g.liakhovetski@gmx.de
Cc: linux-serial@vger.kernel.org
Sent: Tue, 15 Apr 2008 4:30 pm
Subject: Re: Change to serial_core.c .... causing my serial driver 
problem Help Request


Guennadi,

I think the issue is when the serial port is embedded and not connected 
through the bus. So I am talking about the drivers in the 
kernel/drivers/serial directory. A few of them use suspend and resume 
and I think they may not be compatible with your change. I not sure who 
signed off on in but I am having problems with the change and would 
like to like to get it resolved.  

Do you know if you anybody tested any serial ports that are located in 
that directory and use  the suspend and resume calls. Ports not 
connected through a bus.

Vipul




-----Original Message-----
From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
To: vcgandhi1@aol.com
Cc: linux-serial@vger.kernel.org
Sent: Tue, 15 Apr 2008 3:49 pm
Subject: RE: Change to serial_core.c .... causing my serial driver 
problem Help Request



On Tue, 15 Apr 2008, vcgandhi1@aol.com wrote:

> Will do,

I added linux-serial to cc.

> But it seems like the code that was check in has issues.

Given the number and names of signed-off's under this patch, it is 
pretty
unlikely.

> If you look in
> the directory no serial driver properly sets port->dev to be pointing 
to
> the parent. It looks like they all point to themselves. Can you tell 
me
> which driver you tested this change on. I can look to see how they 
set
> port->dev.

8250_pci.c, and I do think it sets it properly in 
pciserial_init_ports().

Thanks
Guennadi

> Vipul?
> ?
>
> -----Original Message-----
> From: Guennadi Liakhovetski [mailto:g.liakhovetski@gmx.de]
> Sent: Tuesday, April 15, 2008 2:50 PM
> To: Gandhi, Vipul
> Subject: Re: Change to serial_core.c .... causing my serial driver 
problem
Help Request
>
> ?
>
> On Tue, 15 Apr 2008, Gandhi, Vipul wrote:
>
> ?
>
> > For my driver the following call is returning a NULL .?????????
>
> >
>
> >?
>
> >
>
> > tty_dev = device_find_child(port->dev, &match, serial_match_port);
>
> >
>
> >?
>
> >
>
> > Any idea? why, previously this was not in serial_core.c but was 
recently
>
> > added by you I believe. Any help would be appreciated.
>
> ?
>
> No, not without seeing the source-code of your driver. Also, please,
>
> direct such questions to the linux-serial or linux-kernel mailing 
list,
>
> you may then additionally CC the person, who you think can help you 
best.
>
> ?
>
> Thanks
>
> Guennadi
>
> ---
>
> Guennadi Liakhovetski
>

---
Guennadi Liakhovetski
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html