From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B585F343D85; Thu, 11 Sep 2025 14:35:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757601308; cv=none; b=nBrm4ne+dKX+Nh8u016lv2cGOuPeKuHoaCSzVdlWpU+NwH5wMm7O1y2WEotaEIPVGAnKmyIAl+kF4M1Dfnmc+dz02H5kQLVtaxQl8lwryXSCWx8DxI9/RXcfMCft78X6FhKvinCWwn35JwH7JOwMko+K7Jw6bSMtW8nwhBGW5qM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757601308; c=relaxed/simple; bh=lxH4g4rfuVupITpyNiYn0jyUWYGJEu6MhvfViL4ipQo=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=JojLcIxHKC38/yDoZ4JOm06QQwmUtRDDZiUKn7wBLR87Ndp8Dngb8GD2xBUWo5C9YmoBovjroKGLjDfWg1d5XXUsbiI1pU/pUFcusvoo7Ihrr2W3Gu+MopuJIxUrq7ITbTq1pUU2Zj6X/pwdWO81K2wG3CelZUE8d53fUIgCCWA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UPcZbDIl; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UPcZbDIl" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4AC89C4CEF0; Thu, 11 Sep 2025 14:35:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757601308; bh=lxH4g4rfuVupITpyNiYn0jyUWYGJEu6MhvfViL4ipQo=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=UPcZbDIlob4l1tpZOsBnHtIv4ct4gWb7ifBmzpuffPmTeALf/RC/PFrHl/GcSMN7Y gz4YUjYuTKPHFzmyVpya/j4D54MrBtrXIvGaswOJDITTJ0B+ZySblVLoF7kdij4Igj 6aEOpcgOfFhiZST01pihS2QEaJP+EtP7XX66ydKADsQqj+YfIfQL3Jskz6X80wt/b0 LG/fhTvCF9skfYjxtAd3s0QMAur4IeMDqAiRZkPJPuE4VOcSBzjSM0BKNn+Hw4ckkk TFbwGrY4GbW8dzUSZEurobqpCTiU1QaIxfW+/QRcpzpJzRk2DFSt0aFQuQJrYUbBiu 9QsmwYsJGe+og== Message-ID: <8aeda67e-404e-4deb-ac90-015f2325ef64@kernel.org> Date: Thu, 11 Sep 2025 16:35:00 +0200 Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] tty: serial: samsung: Remove unused artpec-8 specific code From: Krzysztof Kozlowski To: Geert Uytterhoeven , Ravi Patel Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, jesper.nilsson@axis.com, lars.persson@axis.com, alim.akhtar@samsung.com, arnd@kernel.org, andriy.shevchenko@linux.intel.com, geert+renesas@glider.be, thierry.bultel.yh@bp.renesas.com, dianders@chromium.org, robert.marko@sartura.hr, schnelle@linux.ibm.com, kkartik@nvidia.com, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@axis.com, ksk4725@coasia.com, kenkim@coasia.com, smn1196@coasia.com, pjsin865@coasia.com, shradha.t@samsung.com References: <20250911141605.13034-1-ravi.patel@samsung.com> <20250911141605.13034-4-ravi.patel@samsung.com> <6df0e227-896b-438a-913e-95b637aa2b14@kernel.org> Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <6df0e227-896b-438a-913e-95b637aa2b14@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 11/09/2025 16:29, Krzysztof Kozlowski wrote: >>> --- a/drivers/tty/serial/samsung_tty.c >>> +++ b/drivers/tty/serial/samsung_tty.c >> >>> @@ -2655,8 +2621,6 @@ static const struct of_device_id s3c24xx_uart_dt_match[] = { >>> .data = S5L_SERIAL_DRV_DATA }, >>> { .compatible = "samsung,exynos850-uart", >>> .data = EXYNOS850_SERIAL_DRV_DATA }, >>> - { .compatible = "axis,artpec8-uart", >>> - .data = ARTPEC8_SERIAL_DRV_DATA }, >>> { .compatible = "google,gs101-uart", >>> .data = GS101_SERIAL_DRV_DATA }, >>> { .compatible = "samsung,exynos8895-uart", >>> @@ -2828,8 +2792,6 @@ OF_EARLYCON_DECLARE(s5pv210, "samsung,s5pv210-uart", >>> s5pv210_early_console_setup); >>> OF_EARLYCON_DECLARE(exynos4210, "samsung,exynos4210-uart", >>> s5pv210_early_console_setup); >>> -OF_EARLYCON_DECLARE(artpec8, "axis,artpec8-uart", >>> - s5pv210_early_console_setup); >>> >>> static int __init gs101_early_console_setup(struct earlycon_device *device, >>> const char *opt) >> >> Removing these breaks backwards-compatibility with existing DTBs, >> which lack the new "samsung,exynos8895-uart" fallback compatible value. > > This was just applied, so ABI break would be fine. It should be however > clearly expressed in the commit msg. > > I have a feeling that not much testing was happening in Samsung around > this patchset and only now - after I applied it - some things happen. > But it is damn too late, my tree is already closed which means this is > going to be the ABI. Ah, no, I mixed up patches with recent DTS for Artpec-8. This serial ABI was accepted three years ago (!!!), so you are Geert absolutely right - that's ABI break. Folks in Samsung, maybe try to organize some weekly sessions sharing knowledge after upstreaming reviews/feedbacks? I feel like you are repeating same mistakes. Best regards, Krzysztof