Re: [PATCH] hvc/xen: Check console connection flag

[Jiri Slaby <jirislaby@kernel.org>]

On 12. 03. 26, 18:38, Jason Andryuk wrote:
> --- a/include/xen/interface/io/console.h
> +++ b/include/xen/interface/io/console.h
> @@ -19,6 +19,19 @@ struct xencons_interface {
>       char out[2048];
>       XENCONS_RING_IDX in_cons, in_prod;
>       XENCONS_RING_IDX out_cons, out_prod;
> +/*
> + * Flag values signaling from backend to frontend whether the console is
> + * connected.  i.e. Whether it will be serviced and emptied.
> + *
> + * The flag starts as disconnected.
> + */
> +#define XENCONSOLE_DISCONNECTED 1
> +/*
> + * The flag is set to connected when the backend connects and the console
> + * will be serviced.
> + */
> +#define XENCONSOLE_CONNECTED    0

This all should be an enum. And you can document it using kernel-doc 
properly then.

> +    uint8_t connection;

And type check as well.

thanks,
-- 
js
suse labs