From: Jiri Slaby <jirislaby@kernel.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-serial <linux-serial@vger.kernel.org>
Subject: Re: [PATCH RESEND] serial: men_z135_uart: Drop duplicated iotype assignment
Date: Mon, 9 May 2022 12:42:05 +0200 [thread overview]
Message-ID: <907f41dd-aa3b-1456-6fac-b7014c791641@kernel.org> (raw)
In-Reply-To: <14b71e1-2396-3d83-3a97-9582765d453@linux.intel.com>
On 04. 05. 22, 9:28, Ilpo Järvinen wrote:
> The driver assigns same iotype twice. Drop one of them.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
> ---
>
> Resending with correct linux-serial address.
>
> drivers/tty/serial/men_z135_uart.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/tty/serial/men_z135_uart.c b/drivers/tty/serial/men_z135_uart.c
> index 9acae5f8fc32..12117b596e73 100644
> --- a/drivers/tty/serial/men_z135_uart.c
> +++ b/drivers/tty/serial/men_z135_uart.c
> @@ -833,7 +833,6 @@ static int men_z135_probe(struct mcb_device *mdev,
> uart->port.iotype = UPIO_MEM;
> uart->port.ops = &men_z135_ops;
> uart->port.irq = mcb_get_irq(mdev);
> - uart->port.iotype = UPIO_MEM;
> uart->port.flags = UPF_BOOT_AUTOCONF | UPF_IOREMAP;
> uart->port.line = line++;
> uart->port.dev = dev;
>
--
js
suse labs
prev parent reply other threads:[~2022-05-09 10:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 7:28 [PATCH RESEND] serial: men_z135_uart: Drop duplicated iotype assignment Ilpo Järvinen
2022-05-09 10:42 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=907f41dd-aa3b-1456-6fac-b7014c791641@kernel.org \
--to=jirislaby@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).