* [PATCH RESEND] serial: men_z135_uart: Drop duplicated iotype assignment
@ 2022-05-04 7:28 Ilpo Järvinen
2022-05-09 10:42 ` Jiri Slaby
0 siblings, 1 reply; 2+ messages in thread
From: Ilpo Järvinen @ 2022-05-04 7:28 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby, linux-serial
[-- Attachment #1: Type: text/plain, Size: 836 bytes --]
The driver assigns same iotype twice. Drop one of them.
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
Resending with correct linux-serial address.
drivers/tty/serial/men_z135_uart.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/tty/serial/men_z135_uart.c b/drivers/tty/serial/men_z135_uart.c
index 9acae5f8fc32..12117b596e73 100644
--- a/drivers/tty/serial/men_z135_uart.c
+++ b/drivers/tty/serial/men_z135_uart.c
@@ -833,7 +833,6 @@ static int men_z135_probe(struct mcb_device *mdev,
uart->port.iotype = UPIO_MEM;
uart->port.ops = &men_z135_ops;
uart->port.irq = mcb_get_irq(mdev);
- uart->port.iotype = UPIO_MEM;
uart->port.flags = UPF_BOOT_AUTOCONF | UPF_IOREMAP;
uart->port.line = line++;
uart->port.dev = dev;
--
tg: (672c0c517342..) cleanup/dbl_iotype_assign (depends on: master)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH RESEND] serial: men_z135_uart: Drop duplicated iotype assignment
2022-05-04 7:28 [PATCH RESEND] serial: men_z135_uart: Drop duplicated iotype assignment Ilpo Järvinen
@ 2022-05-09 10:42 ` Jiri Slaby
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Slaby @ 2022-05-09 10:42 UTC (permalink / raw)
To: Ilpo Järvinen, Greg Kroah-Hartman, linux-serial
On 04. 05. 22, 9:28, Ilpo Järvinen wrote:
> The driver assigns same iotype twice. Drop one of them.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
> ---
>
> Resending with correct linux-serial address.
>
> drivers/tty/serial/men_z135_uart.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/tty/serial/men_z135_uart.c b/drivers/tty/serial/men_z135_uart.c
> index 9acae5f8fc32..12117b596e73 100644
> --- a/drivers/tty/serial/men_z135_uart.c
> +++ b/drivers/tty/serial/men_z135_uart.c
> @@ -833,7 +833,6 @@ static int men_z135_probe(struct mcb_device *mdev,
> uart->port.iotype = UPIO_MEM;
> uart->port.ops = &men_z135_ops;
> uart->port.irq = mcb_get_irq(mdev);
> - uart->port.iotype = UPIO_MEM;
> uart->port.flags = UPF_BOOT_AUTOCONF | UPF_IOREMAP;
> uart->port.line = line++;
> uart->port.dev = dev;
>
--
js
suse labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-09 10:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-04 7:28 [PATCH RESEND] serial: men_z135_uart: Drop duplicated iotype assignment Ilpo Järvinen
2022-05-09 10:42 ` Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).