From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Christoph Niedermaier <cniedermaier@dh-electronics.com>,
linux-serial@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: krzysztof.kozlowski+dt@linaro.org, marex@denx.de,
jirislaby@kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Alexander Dahl <ada@thorsis.com>,
kernel@dh-electronics.com, devicetree@vger.kernel.org
Subject: Re: [PATCH V2 1/4] dt_bindings: rs485: Add binding for GPIO that controls Rx enable during Tx
Date: Thu, 24 Nov 2022 11:03:18 +0100 [thread overview]
Message-ID: <93a88b73-a600-1cee-43d2-0e7b72ceba3e@linaro.org> (raw)
In-Reply-To: <20221123123004.7216-1-cniedermaier@dh-electronics.com>
On 23/11/2022 13:30, Christoph Niedermaier wrote:
> This patch adds a binding for a generic definition of an output GPIO that
Do not use "This commit/patch".
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
> indicates the state of rs485-rx-during-tx. The idea is that the hardware
1. Use subject prefixes matching the subsystem (git log --oneline -- ...).
(no underscores)
2. Subject: drop second, redundant "bindings".
So it could look like:
dt-bindings: serial: rs485: Add GPIO controlling RX enable during TX
For the ack of contents, I'll leave it to Rob as he was involved in v1
discussion.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-24 10:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 12:30 [PATCH V2 1/4] dt_bindings: rs485: Add binding for GPIO that controls Rx enable during Tx Christoph Niedermaier
2022-11-23 12:30 ` [PATCH V2 2/4] serial: core: Add option to output RS485 RX_DURING_TX state via GPIO Christoph Niedermaier
2022-11-23 12:30 ` [PATCH V2 3/4] serial: imx: Add support for RS485 RX_DURING_TX output GPIO Christoph Niedermaier
2022-11-23 12:30 ` [PATCH V2 4/4] serial: stm32: Add support for rs485 " Christoph Niedermaier
2022-11-24 10:03 ` Krzysztof Kozlowski [this message]
2022-11-30 21:15 ` [PATCH V2 1/4] dt_bindings: rs485: Add binding for GPIO that controls Rx enable during Tx Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93a88b73-a600-1cee-43d2-0e7b72ceba3e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=ada@thorsis.com \
--cc=cniedermaier@dh-electronics.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kernel@dh-electronics.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=marex@denx.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).