Linux Serial subsystem development
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: your change "serial: 8250: move RSA functions to 8250_rsa.c"
Date: Tue, 21 Oct 2025 08:22:53 +0200	[thread overview]
Message-ID: <9515bd4c-4bb6-4535-818c-283e69feb0a7@suse.com> (raw)

Jiri,

in this change you moved code from 8250_base to 8250. The latter has always
had a dependency on the former. Now the former has gained a dependency on
the latter, i.e. a circular dependency was introduced. Maybe modern module
loading tools can handle that; on the first (older) system I tried they
can't, and I had to resort to setting SERIAL_8250_RSA=n as a workaround.

One related question that came to mind: Seeing that both drivers are built
depending on the SERIAL_8250 setting, why are they separate modules anyway?

Jan

             reply	other threads:[~2025-10-21  6:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-21  6:22 Jan Beulich [this message]
2025-11-07  6:23 ` your change "serial: 8250: move RSA functions to 8250_rsa.c" Jiri Slaby
2025-11-07  7:02   ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9515bd4c-4bb6-4535-818c-283e69feb0a7@suse.com \
    --to=jbeulich@suse.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox