Re: [PATCH v2] serial: 8250: Fix THRE flag usage for CAP_MINI

[Phil Elwell <phil-FnsA7b+Nu9XbIbC87yuRow@public.gmane.org>]

On 28/06/2017 11:57, Uwe Kleine-König wrote:
> Hello,
> 
> On Wed, Jun 28, 2017 at 10:41:25AM +0100, Phil Elwell wrote:
>> Signed-off-by: Phil Elwell <phil@raspberrypi.org>
>> Acked-by: Eric Anholt <eric@anholt.net>
>> Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> ---
>> Changes in v2:
>>  Add review tags.
> 
> nitpick: The order of lines in the Sob area matter and you should add
> your Sob at the end. So as it was you adding the ack by Eric and Andy,
> it should look as follows:
> 
> 	Acked-by: Eric Anholt <eric@anholt.net>
> 	Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 	Signed-off-by: Phil Elwell <phil@raspberrypi.org>

Really? I thought the submitter went first and the final merger went
last, with other reviewers in-between, like this:

    commit 6df765dca378bddf994cfd2044acafa501bd800f
    Author: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    Date:   Wed May 24 21:38:46 2017 +0200

        serial: imx: ensure UCR3 and UFCR are setup correctly

        [...]

        Fixes: e61c38d85b73 ("serial: imx: setup DCEDTE early and ensure DCD and RI irqs to be off")
        Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
        Acked-by: Mika Penttilä <mika.penttila@nextfour.com>
        Tested-by: Mika Penttilä <mika.penttila@nextfour.com>
        Acked-by: Steve Twiss <stwiss.opensource@diasemi.com>
        Tested-by: Steve Twiss <stwiss.opensource@diasemi.com>
        Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

> . Note that this comment is very picky, quite some people don't get it
> right and I never saw a maintainer refuse a patch because of this. So
> this probably doesn't warrant a v3 :-)
> 
> Best regards
> Uwe
> 

_______________________________________________
linux-rpi-kernel mailing list
linux-rpi-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rpi-kernel