Re: [PATCH 28/33] serial: 8250: remove debug prints from ISR

Ilpo Järvinen
2025-06-11T13:10:05Z

[-- Attachment #1: Type: text/plain, Size: 1045 bytes --]

On Wed, 11 Jun 2025, Jiri Slaby (SUSE) wrote:

> These are useless, we have tracing nowadays.
>
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
> ---
> drivers/tty/serial/8250/8250_core.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
> index d42ceb6ffdc2..2bac9c7827de 100644
> --- a/drivers/tty/serial/8250/8250_core.c
> +++ b/drivers/tty/serial/8250/8250_core.c
> @@ -71,8 +71,6 @@ static irqreturn_t serial8250_interrupt(int irq, void *dev_id)
> struct list_head *l, *end = NULL;
> int pass_counter = 0, handled = 0;
>
> - pr_debug("%s(%d): start\n", __func__, irq);
> -
> spin_lock(&i->lock);
>
> l = i->head;
> @@ -97,8 +95,6 @@ static irqreturn_t serial8250_interrupt(int irq, void *dev_id)
>
> spin_unlock(&i->lock);
>
> - pr_debug("%s(%d): end\n", __func__, irq);
> -
> return IRQ_RETVAL(handled);
> }
>
>

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

--
i.