From: Krzysztof Kozlowski <krzk@kernel.org>
To: Wenhua Lin <Wenhua.Lin@unisoc.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Cixi Geng <cixi.geng@linux.dev>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
devicetree@vger.kernel.org, wenhua lin <wenhua.lin1994@gmail.com>,
Xiongpeng Wu <xiongpeng.wu@unisoc.com>,
Zhaochen Su <Zhaochen.Su@unisoc.com>,
Zhirong Qiu <Zhirong.Qiu@unisoc.com>
Subject: Re: [PATCH V2 1/2] dt-bindings: serial: Add a new compatible string for UMS9632
Date: Mon, 13 Jan 2025 08:53:46 +0100 [thread overview]
Message-ID: <987b764e-17a6-4280-95e2-858d4c74a8d5@kernel.org> (raw)
In-Reply-To: <20250113031917.3354988-2-Wenhua.Lin@unisoc.com>
On 13/01/2025 04:19, Wenhua Lin wrote:
> The UMS9632 uses the SC9632 serial device.
Why are you sending accepted patches?
>
> Signed-off-by: Wenhua Lin <Wenhua.Lin@unisoc.com>
> ---
> Documentation/devicetree/bindings/serial/sprd-uart.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.yaml b/Documentation/devicetree/bindings/serial/sprd-uart.yaml
> index f4dbb6dc2b6e..83582aa6c750 100644
> --- a/Documentation/devicetree/bindings/serial/sprd-uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/sprd-uart.yaml
> @@ -23,6 +23,11 @@ properties:
> - sprd,ums9620-uart
> - const: sprd,sc9836-uart
> - const: sprd,sc9836-uart
> + - items:
> + - enum:
> + - sprd,ums9632-uart
> + - const: sprd,sc9632-uart
> + - const: sprd,sc9632-uart
NAK, you are duplicating entries.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-01-13 7:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 3:19 [PATCH V2 0/2] serial: sprd: Modification of UNISOC Platform UART Driver Wenhua Lin
2025-01-13 3:19 ` [PATCH V2 1/2] dt-bindings: serial: Add a new compatible string for UMS9632 Wenhua Lin
2025-01-13 7:53 ` Krzysztof Kozlowski [this message]
2025-01-13 3:19 ` [PATCH V2 2/2] serial: sprd: Add support for sc9632 Wenhua Lin
2025-01-13 6:07 ` Baolin Wang
2025-01-14 2:03 ` wenhua lin
2025-01-13 7:12 ` Chunyan Zhang
2025-01-14 2:25 ` wenhua lin
2025-01-13 6:05 ` [PATCH V2 0/2] serial: sprd: Modification of UNISOC Platform UART Driver Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=987b764e-17a6-4280-95e2-858d4c74a8d5@kernel.org \
--to=krzk@kernel.org \
--cc=Wenhua.Lin@unisoc.com \
--cc=Zhaochen.Su@unisoc.com \
--cc=Zhirong.Qiu@unisoc.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=brgl@bgdev.pl \
--cc=cixi.geng@linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=robh@kernel.org \
--cc=wenhua.lin1994@gmail.com \
--cc=xiongpeng.wu@unisoc.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox