From: Mike Frysinger <vapier@gentoo.org>
To: linux-serial@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: uclinux-dist-devel@blackfin.uclinux.org
Subject: Re: [uclinux-dist-devel] [PATCH] serial: bfin_5xx: split uart RX lock from uart port lock to avoid deadlock
Date: Thu, 3 Feb 2011 01:29:08 -0500 [thread overview]
Message-ID: <AANLkTi=Kp6ix8j5dG6RTySZcScTnRBKsVReTp7v0Y8XP@mail.gmail.com> (raw)
In-Reply-To: <1294723003-8496-1-git-send-email-vapier@gentoo.org>
On Tue, Jan 11, 2011 at 00:16, Mike Frysinger wrote:
> From: Sonic Zhang <sonic.zhang@analog.com>
>
> The RX lock is used to protect the RX buffer from concurrent access in DMA
> mode between the timer and RX interrupt routines. It is independent from
> the uart lock which is used to protect the TX buffer. It is possible for
> a uart TX transfer to be started up from the RX interrupt handler if low
> latency is enabled. So we need to split the locks to avoid deadlocking in
> this situation.
>
> In PIO mode, the RX lock is not necessary because the handle_simple_irq
> and handle_level_irq functions ensure driver interrupt handlers are called
> once on one core.
>
> And now that the RX path has its own lock, the TX interrupt has nothing to
> do with the RX path, so disabling it at the same time.
ping ...
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-02-03 6:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-11 5:16 [PATCH] serial: bfin_5xx: split uart RX lock from uart port lock to avoid deadlock Mike Frysinger
2011-02-03 6:29 ` Mike Frysinger [this message]
2011-02-03 18:32 ` [uclinux-dist-devel] " Greg KH
2011-02-03 21:56 ` Mike Frysinger
2011-02-03 22:05 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=Kp6ix8j5dG6RTySZcScTnRBKsVReTp7v0Y8XP@mail.gmail.com' \
--to=vapier@gentoo.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@suse.de \
--cc=linux-serial@vger.kernel.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).