From: Grant Likely <grant.likely@secretlab.ca>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: michal.simek@petalogix.com, johnlinn@comcast.net,
Greg KH <greg@kroah.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
joe@perches.com, John Linn <john.linn@xilinx.com>
Subject: Re: [PATCH V4] tty/serial: add support for Xilinx PS UART
Date: Fri, 6 May 2011 10:41:34 -0600 [thread overview]
Message-ID: <BANLkTi=1guAvjXO2FVOPV+4=p53jeU3vUQ@mail.gmail.com> (raw)
In-Reply-To: <20110506132344.1d166260@lxorguk.ukuu.org.uk>
On Fri, May 6, 2011 at 6:23 AM, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
>> I don't agree with this change. NO_IRQ for microblaze, arm and other is -1. BTW:
>> For ppc is 0. Using NO_IRQ seems to me reasonable.
>
> 0 means "no interrupt".
>
> The old mis-use of -1 is an old mostly ARM specific ugly that ahould be
> going away not getting repeated further. If Microblaze is using this hack
> then it needs to stop.
This will be easier for microblaze when I finish the irq_domain work.
There are patches on the list, but they need to be reworked before
they are ready for mainline consumption.
g.
next prev parent reply other threads:[~2011-05-06 16:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-27 18:17 [PATCH V4] tty/serial: add support for Xilinx PS UART johnlinn
2011-04-27 20:40 ` Alan Cox
2011-04-27 20:57 ` johnlinn
2011-04-29 21:14 ` Greg KH
2011-04-29 21:29 ` johnlinn
2011-04-29 21:32 ` Alan Cox
2011-04-29 21:41 ` johnlinn
2011-05-06 12:11 ` Michal Simek
2011-05-06 12:23 ` Alan Cox
2011-05-06 16:41 ` Grant Likely [this message]
2011-04-29 22:02 ` johnlinn
2011-04-29 23:29 ` Greg KH
[not found] <681890114.2094084.1304112868616.JavaMail.root@sz0140a.emeryville.ca.mail.comcast.net>
2011-04-29 21:35 ` johnlinn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=1guAvjXO2FVOPV+4=p53jeU3vUQ@mail.gmail.com' \
--to=grant.likely@secretlab.ca \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=joe@perches.com \
--cc=john.linn@xilinx.com \
--cc=johnlinn@comcast.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=michal.simek@petalogix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).