From: Roland Dreier <roland@kernel.org>
To: Alexander Stein <alexander.stein@systec-electronic.com>
Cc: Alan Cox <alan@linux.intel.com>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
Tomoya MORINAGA <tomoya-linux@dsn.okisemi.com>
Subject: Re: [PATCH] pch_uart: Add MSI support
Date: Wed, 22 Jun 2011 17:34:27 -0700 [thread overview]
Message-ID: <BANLkTim+2Vs7nZqgDnEes5-+CZmuK7_RhA@mail.gmail.com> (raw)
In-Reply-To: <1308736219-19975-1-git-send-email-alexander.stein@systec-electronic.com>
On Wed, Jun 22, 2011 at 2:50 AM, Alexander Stein
<alexander.stein@systec-electronic.com> wrote:
> + if (priv->use_msi)
> + pci_disable_msi(pdev);
Trivial nit: pci_disable_msi() is safe even if you didn't enable msi.
So you can drop the use_msi flag (the PCI layer has dev->msi_enabled
internally to track this), and just always call pci_disable_msi().
- R.
prev parent reply other threads:[~2011-06-23 0:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-22 9:50 [PATCH] pch_uart: Add MSI support Alexander Stein
2011-06-23 0:14 ` Tomoya MORINAGA
2011-06-23 7:00 ` [PATCH v2] " Alexander Stein
2011-06-23 7:16 ` Clemens Ladisch
2011-06-23 7:37 ` Alexander Stein
2011-07-01 22:32 ` Greg KH
2011-07-04 6:58 ` [PATCH v3] " Alexander Stein
2011-07-22 12:39 ` Tomoya MORINAGA
2011-07-19 4:15 ` serial/pch_uart: AT command behavior Tomoya MORINAGA
2011-07-19 9:06 ` Alan Cox
2011-07-20 0:14 ` Tomoya MORINAGA
2011-07-20 12:49 ` Alan Cox
2011-06-23 0:34 ` Roland Dreier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTim+2Vs7nZqgDnEes5-+CZmuK7_RhA@mail.gmail.com \
--to=roland@kernel.org \
--cc=alan@linux.intel.com \
--cc=alexander.stein@systec-electronic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=tomoya-linux@dsn.okisemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).