[PATCHv2 1/2] dt: document the of_serial bindings

[PATCHv2 1/2] dt: document the of_serial bindings

[Jamie Iles]

The of_serial bindings can be used to register a number of serial
devices.  Document this binding with all of the others.

Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Jamie Iles <jamie@jamieiles.com>
---
 .../devicetree/bindings/tty/serial/of-serial.txt   |   34 ++++++++++++++++++++
 1 files changed, 34 insertions(+), 0 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/tty/serial/of-serial.txt

diff --git a/Documentation/devicetree/bindings/tty/serial/of-serial.txt b/Documentation/devicetree/bindings/tty/serial/of-serial.txt
new file mode 100644
index 0000000..b0c52c2
--- /dev/null
+++ b/Documentation/devicetree/bindings/tty/serial/of-serial.txt
@@ -0,0 +1,34 @@
+* UART (Universal Asynchronous Receiver/Transmitter)
+
+Required properties:
+- compatible : one of:
+	- "ns8250"
+	- "ns16450"
+	- "ns16550a"
+	- "ns16550"
+	- "ns16750"
+	- "ns16850"
+	- "nvidia,tegra250-uart"
+	- "ibm,qpace-nwp-serial"
+	- "serial" if the port type is unknown.
+- reg : offset and length of the register set for the device.
+- interrupts : should contain uart interrupt.
+- clock-frequency : the input clock frequency for the UART.
+
+Optional properties:
+- current-speed : the current active speed of the UART.
+- reg-offset : offset to apply to the mapbase from the start of the registers.
+- reg-shift : quantity to shift the register offsets by.
+- used-by-rtas : set to indicate that the port is in use by the firmware and
+  should not be registered.
+
+Example:
+
+	uart@80230000 {
+		compatible = "ns8250";
+		device-type = "serial";
+		reg = <0x80230000 0x100>;
+		clock-frequency = <3686400>;
+		interrupts = <10>;
+		reg-shift = <2>;
+	};
-- 
1.7.4.1

[PATCHv2 2/2] tty: of_serial: support for 32 bit accesses

[Jamie Iles]

Some platforms e.g. TI Davinci require 32-bit accesses to the UARTs.
The of_serial driver currently registers all UARTs as UPIO_MEM.  Add a
new attribute "io-width" to allow the port to be registered with
different IO width requirements.

v2: replace dev_warn() with dev_err()

Acked-by: Alan Cox <alan@linux.intel.com>
Acked-by: Grant Likely <grant.likely@secretlab.ca>
Signed-off-by: Jamie Iles <jamie@jamieiles.com>
---
 .../devicetree/bindings/tty/serial/of-serial.txt   |    3 +++
 drivers/tty/serial/of_serial.c                     |   17 +++++++++++++++++
 2 files changed, 20 insertions(+), 0 deletions(-)

diff --git a/Documentation/devicetree/bindings/tty/serial/of-serial.txt b/Documentation/devicetree/bindings/tty/serial/of-serial.txt
index b0c52c2..1771cda 100644
--- a/Documentation/devicetree/bindings/tty/serial/of-serial.txt
+++ b/Documentation/devicetree/bindings/tty/serial/of-serial.txt
@@ -21,6 +21,9 @@ Optional properties:
 - reg-shift : quantity to shift the register offsets by.
 - used-by-rtas : set to indicate that the port is in use by the firmware and
   should not be registered.
+- io-width : the size (in bytes) of the IO accesses that should be performed
+  on the device.  There are some systems that require 32-bit accesses to the
+  UART (e.g. TI davinci).
 
 Example:
 
diff --git a/drivers/tty/serial/of_serial.c b/drivers/tty/serial/of_serial.c
index c911b24..82af1fc 100644
--- a/drivers/tty/serial/of_serial.c
+++ b/drivers/tty/serial/of_serial.c
@@ -65,6 +65,23 @@ static int __devinit of_platform_serial_setup(struct platform_device *ofdev,
 
 	port->irq = irq_of_parse_and_map(np, 0);
 	port->iotype = UPIO_MEM;
+	prop = of_get_property(np, "io-width", &prop_size);
+	if (prop && (prop_size == sizeof(u32))) {
+		switch (be32_to_cpup(prop)) {
+		case 1:
+			port->iotype = UPIO_MEM;
+			break;
+		case 4:
+			port->iotype = UPIO_MEM32;
+			break;
+		default:
+			dev_err(&ofdev->dev,
+				"unsupported io width (%d bytes)\n",
+				be32_to_cpup(prop));
+			return -EINVAL;
+		}
+	}
+
 	port->type = type;
 	port->uartclk = be32_to_cpup(clk);
 	port->flags = UPF_SHARE_IRQ | UPF_BOOT_AUTOCONF | UPF_IOREMAP
-- 
1.7.4.1

Re: [PATCHv2 1/2] dt: document the of_serial bindings

[Grant Likely]

On Thu, Jun 23, 2011 at 8:08 AM, Jamie Iles <jamie@jamieiles.com> wrote:
> The of_serial bindings can be used to register a number of serial
> devices.  Document this binding with all of the others.
>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Jamie Iles <jamie@jamieiles.com>
> ---
>  .../devicetree/bindings/tty/serial/of-serial.txt   |   34 ++++++++++++++++++++
>  1 files changed, 34 insertions(+), 0 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/tty/serial/of-serial.txt
>
> diff --git a/Documentation/devicetree/bindings/tty/serial/of-serial.txt b/Documentation/devicetree/bindings/tty/serial/of-serial.txt
> new file mode 100644
> index 0000000..b0c52c2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/tty/serial/of-serial.txt
> @@ -0,0 +1,34 @@
> +* UART (Universal Asynchronous Receiver/Transmitter)
> +
> +Required properties:
> +- compatible : one of:
> +       - "ns8250"
> +       - "ns16450"
> +       - "ns16550a"
> +       - "ns16550"
> +       - "ns16750"
> +       - "ns16850"
> +       - "nvidia,tegra250-uart"
> +       - "ibm,qpace-nwp-serial"
> +       - "serial" if the port type is unknown.
> +- reg : offset and length of the register set for the device.
> +- interrupts : should contain uart interrupt.
> +- clock-frequency : the input clock frequency for the UART.
> +
> +Optional properties:
> +- current-speed : the current active speed of the UART.
> +- reg-offset : offset to apply to the mapbase from the start of the registers.
> +- reg-shift : quantity to shift the register offsets by.
> +- used-by-rtas : set to indicate that the port is in use by the firmware and
> +  should not be registered.
> +
> +Example:
> +
> +       uart@80230000 {
> +               compatible = "ns8250";
> +               device-type = "serial";

Drop device-type.  Otherwise looks good.

g.

> +               reg = <0x80230000 0x100>;
> +               clock-frequency = <3686400>;
> +               interrupts = <10>;
> +               reg-shift = <2>;
> +       };
> --
> 1.7.4.1
>
>



-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCHv2 1/2] dt: document the of_serial bindings

[Grant Likely]

On Thu, Jun 23, 2011 at 8:55 AM, Grant Likely <grant.likely@secretlab.ca> wrote:
> On Thu, Jun 23, 2011 at 8:08 AM, Jamie Iles <jamie@jamieiles.com> wrote:
>> The of_serial bindings can be used to register a number of serial
>> devices.  Document this binding with all of the others.
>>
>> Cc: Grant Likely <grant.likely@secretlab.ca>
>> Cc: Arnd Bergmann <arnd@arndb.de>
>> Signed-off-by: Jamie Iles <jamie@jamieiles.com>
>> ---
>>  .../devicetree/bindings/tty/serial/of-serial.txt   |   34 ++++++++++++++++++++
>>  1 files changed, 34 insertions(+), 0 deletions(-)
>>  create mode 100644 Documentation/devicetree/bindings/tty/serial/of-serial.txt
>>
>> diff --git a/Documentation/devicetree/bindings/tty/serial/of-serial.txt b/Documentation/devicetree/bindings/tty/serial/of-serial.txt
>> new file mode 100644
>> index 0000000..b0c52c2
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/tty/serial/of-serial.txt
>> @@ -0,0 +1,34 @@
>> +* UART (Universal Asynchronous Receiver/Transmitter)
>> +
>> +Required properties:
>> +- compatible : one of:
>> +       - "ns8250"
>> +       - "ns16450"
>> +       - "ns16550a"
>> +       - "ns16550"
>> +       - "ns16750"
>> +       - "ns16850"
>> +       - "nvidia,tegra250-uart"
>> +       - "ibm,qpace-nwp-serial"
>> +       - "serial" if the port type is unknown.
>> +- reg : offset and length of the register set for the device.
>> +- interrupts : should contain uart interrupt.
>> +- clock-frequency : the input clock frequency for the UART.
>> +
>> +Optional properties:
>> +- current-speed : the current active speed of the UART.
>> +- reg-offset : offset to apply to the mapbase from the start of the registers.
>> +- reg-shift : quantity to shift the register offsets by.
>> +- used-by-rtas : set to indicate that the port is in use by the firmware and
>> +  should not be registered.
>> +
>> +Example:
>> +
>> +       uart@80230000 {
>> +               compatible = "ns8250";
>> +               device-type = "serial";
>
> Drop device-type.  Otherwise looks good.

Although the used-by-rtas description should probably mention
specifically that it is used by OpenFirmware RTAS.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCHv2 1/2] dt: document the of_serial bindings

[Grant Likely]

On Thu, Jun 23, 2011 at 8:56 AM, Grant Likely <grant.likely@secretlab.ca> wrote:
> On Thu, Jun 23, 2011 at 8:55 AM, Grant Likely <grant.likely@secretlab.ca> wrote:
>> On Thu, Jun 23, 2011 at 8:08 AM, Jamie Iles <jamie@jamieiles.com> wrote:
>>> The of_serial bindings can be used to register a number of serial
>>> devices.  Document this binding with all of the others.
>>>
>>> Cc: Grant Likely <grant.likely@secretlab.ca>
>>> Cc: Arnd Bergmann <arnd@arndb.de>
>>> Signed-off-by: Jamie Iles <jamie@jamieiles.com>
>>> ---
>>>  .../devicetree/bindings/tty/serial/of-serial.txt   |   34 ++++++++++++++++++++
>>>  1 files changed, 34 insertions(+), 0 deletions(-)
>>>  create mode 100644 Documentation/devicetree/bindings/tty/serial/of-serial.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/tty/serial/of-serial.txt b/Documentation/devicetree/bindings/tty/serial/of-serial.txt
>>> new file mode 100644
>>> index 0000000..b0c52c2
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/tty/serial/of-serial.txt
>>> @@ -0,0 +1,34 @@
>>> +* UART (Universal Asynchronous Receiver/Transmitter)
>>> +
>>> +Required properties:
>>> +- compatible : one of:
>>> +       - "ns8250"
>>> +       - "ns16450"
>>> +       - "ns16550a"
>>> +       - "ns16550"
>>> +       - "ns16750"
>>> +       - "ns16850"
>>> +       - "nvidia,tegra250-uart"
>>> +       - "ibm,qpace-nwp-serial"
>>> +       - "serial" if the port type is unknown.
>>> +- reg : offset and length of the register set for the device.
>>> +- interrupts : should contain uart interrupt.
>>> +- clock-frequency : the input clock frequency for the UART.
>>> +
>>> +Optional properties:
>>> +- current-speed : the current active speed of the UART.
>>> +- reg-offset : offset to apply to the mapbase from the start of the registers.
>>> +- reg-shift : quantity to shift the register offsets by.
>>> +- used-by-rtas : set to indicate that the port is in use by the firmware and
>>> +  should not be registered.
>>> +
>>> +Example:
>>> +
>>> +       uart@80230000 {
>>> +               compatible = "ns8250";
>>> +               device-type = "serial";
>>
>> Drop device-type.  Otherwise looks good.
>
> Although the used-by-rtas description should probably mention
> specifically that it is used by OpenFirmware RTAS.

Oh, and device tree documentation changes should cc: the
devicetree-discuss@lists.ozlabs.org mailing list.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html