From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1F51C433E3 for ; Mon, 24 Aug 2020 10:46:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F0A52074D for ; Mon, 24 Aug 2020 10:46:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UskvNm3E" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726770AbgHXKqC (ORCPT ); Mon, 24 Aug 2020 06:46:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727112AbgHXKpz (ORCPT ); Mon, 24 Aug 2020 06:45:55 -0400 Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 275F0C061573; Mon, 24 Aug 2020 03:45:49 -0700 (PDT) Received: by mail-ej1-x644.google.com with SMTP id md23so10502594ejb.6; Mon, 24 Aug 2020 03:45:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=f6wdlEKoq+5Slr+UsziPsdyk2CY1PCYDCcZCpyAdvwo=; b=UskvNm3ErsbR8Pp/wFDQea/LOjrsQ4lwIZJjMWNn1JqQJYresYEAPXPejRzFL60qex VE2PGxG3z8KRswRMmM0oKcJxH4wfLw5UvtX4JnyAUPoKWu9sxdm0qD/ddj2zaeo5vMgE KZeoYRVzeupKX/SneIEZ9AqQDO61XOR3UAzcYoPFcwipi1OS8bSVvAxM+lct67wWGrRQ WoFGfSl7GIm+5MgTB/3tGzC54KHwQhZaDXdU/hYA/29sWSYgsMo2Xqb3cBh5O/NmY5R9 K9vbAnDlVC3IpZUgmny3LW/UUBYTGqa+eXFV+oY6U5DqQJs1C4JQPbuhL3NgHMj6ka9y dPtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=f6wdlEKoq+5Slr+UsziPsdyk2CY1PCYDCcZCpyAdvwo=; b=BOUAhbn+dwgjhScJXvuiz4Va037vSwo5yd/BDLejfqcvC0VaDZ2mt9vowBb7GZKo7V N/uyQWbDQK8ATzkD3DLTD6NNPQoMretQFkENqTQLoIAo3NdwKVaUhQJ2ypHJLhwyg+AT rUPxHqqLYPzlJmQvRRZsuvbrxVI2KAplyckVV6X7ZlIomwlMlw5D98kCFofGmqunFuKC 0wAQ/ZxgsE7jM2a6MFehnkCIZuTaKrWiMpmsHEdw6Bfoub23kFgMffh0w9hncAX+i4+k L1KlAD4XvdwiXHkB9yfM/fcUTK7/XvCTZj/Xe1sVzjgqzlfrTZLw5K6qy+TenoiVrZND i95w== X-Gm-Message-State: AOAM532enl1T4w0Q4fdYmU947gUZXkr3Nxynbgb1xUJBd2LvgG2t/8mh YPznfxq8yHFQx/9qkPNFZY8Fo5k3riKia2wyo4o= X-Google-Smtp-Source: ABdhPJzEP44NtBFAfTFi6m+U0B8L72BF9hYGNpMJgnWY8VcgZq+4UR0vLLyZ7HOS1sZEFPyg+vJmWEtgQHp7weUp5fA= X-Received: by 2002:a17:906:2a04:: with SMTP id j4mr5218133eje.440.1598265947869; Mon, 24 Aug 2020 03:45:47 -0700 (PDT) MIME-Version: 1.0 References: <20200823161550.3981-1-krzk@kernel.org> <20200823161550.3981-21-krzk@kernel.org> <20200824091102.GA20819@kozik-lap> <20200824103237.GA26120@kozik-lap> In-Reply-To: <20200824103237.GA26120@kozik-lap> From: Dong Aisheng Date: Mon, 24 Aug 2020 18:30:33 +0800 Message-ID: Subject: Re: [PATCH 21/22] arm64: dts: imx8qxp: Remove i.MX7 compatible from USDHC To: Krzysztof Kozlowski Cc: Bough Chen , Aisheng Dong , "devicetree@vger.kernel.org" , "linux-serial@vger.kernel.org" , Anson Huang , "linux-gpio@vger.kernel.org" , Fabio Estevam , Linus Walleij , "linux-pm@vger.kernel.org" , "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-pwm@vger.kernel.org" , Bartosz Golaszewski , Rob Herring , "linux-mtd@lists.infradead.org" , dl-linux-imx , Pengutronix Kernel Team , Thierry Reding , Shawn Guo , Sascha Hauer , "linux-arm-kernel@lists.infradead.org" , "linux-watchdog@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-serial-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Mon, Aug 24, 2020 at 6:32 PM Krzysztof Kozlowski wrote= : > > On Mon, Aug 24, 2020 at 10:31:31AM +0000, Bough Chen wrote: > > > -----Original Message----- > > > From: Dong Aisheng [mailto:dongas86@gmail.com] > > > Sent: 2020=E5=B9=B48=E6=9C=8824=E6=97=A5 17:45 > > > To: Krzysztof Kozlowski > > > Cc: Aisheng Dong ; devicetree@vger.kernel.org; > > > linux-serial@vger.kernel.org; Anson Huang ; > > > linux-gpio@vger.kernel.org; Fabio Estevam ; Linus > > > Walleij ; linux-pm@vger.kernel.org; > > > linux-mmc@vger.kernel.org; linux-kernel@vger.kernel.org; > > > linux-pwm@vger.kernel.org; Bartosz Golaszewski > > > ; Rob Herring ; > > > linux-mtd@lists.infradead.org; dl-linux-imx ; Peng= utronix > > > Kernel Team ; Thierry Reding > > > ; Shawn Guo ; Sascha > > > Hauer ; linux-arm-kernel@lists.infradead.org; > > > linux-watchdog@vger.kernel.org; Bough Chen > > > Subject: Re: [PATCH 21/22] arm64: dts: imx8qxp: Remove i.MX7 compatib= le > > > from USDHC > > > > > > On Mon, Aug 24, 2020 at 5:15 PM Krzysztof Kozlowski > > > wrote: > > > > > > > > On Mon, Aug 24, 2020 at 09:00:19AM +0000, Aisheng Dong wrote: > > > > > > From: Krzysztof Kozlowski > > > > > > Sent: Monday, August 24, 2020 12:16 AM > > > > > > > > > > > > The USDHC on i.MX 8QXP has its own compatible described in > > > > > > bindings and used in the driver (with its own quirks). Remove > > > > > > additional fsl,imx7d-usdhc compatible to fix dtbs_check warning= s like: > > > > > > > > > > > > arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dt.yaml: > > > mmc@5b010000: > > > > > > compatible: ['fsl,imx8qxp-usdhc', 'fsl,imx7d-usdhc'] is too= long > > > > > > From schema: > > > > > > /ocumentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml > > > > > > > > > > > > arch/arm64/boot/dts/freescale/imx8qxp-ai_ml.dt.yaml: > > > mmc@5b010000: > > > > > > compatible: Additional items are not allowed > > > > > > ('fsl,imx7d-usdhc' was > > > > > > unexpected) > > > > > > > > > > > > Signed-off-by: Krzysztof Kozlowski > > > > > > > > > > For Patch 19-22, I think we should fix dt binding doc. > > > > > > > > Are you sure that these USDHC controllers are compatible with i.MX = 7D? > > > > Could they really run with fsl,imx7d-usdhc compatible? > > > > > > AFAIK uSDHC on QXP is derived from the former platforms with adding a= few > > > more new features. e.g. HS400ES/CMDQ. > > > Let me loop in uSDHC driver owner Haibo Chen to double confirm. > > > > Yes, usdhc of imx8qxp can work by using the compatible "fsl, imx7d-usdh= c", but will not support HS400ES/Command Queue any more. Also imx8qxp suppo= rt Auto CMD23, but imx7d not. > > And imx8qxp need to re-config the clock rate after system PM, imx7d do = not need to do this. > > Then we can leave the compatible in DTS and I will correct the device > tree schema. Haibo, As Krzysztof is helping fix uSDHC binding doc in Patch 12/22, please double check with IC for the whole uSDHC derive relationships on i.M= X and feedback to Krzysztof if anything is wrong. Regards Aisheng > > Best regards, > Krzysztof