[PATCH] [PATCH] tty/serial: atmel: add new version check for usart

[PATCH] [PATCH] tty/serial: atmel: add new version check for usart

[Jonas Danielsson]

On our at91sam9260 based board the usart0 and usart1 ports report
their versions (ATMEL_US_VERSION) as 0x10302. This version is not
included in the current checks in the driver.

Signed-off-by: Jonas Danielsson <jonas@orbital-systems.com>
---
 drivers/tty/serial/atmel_serial.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
index efa25611ca0c..ae9f1dcbf3fc 100644
--- a/drivers/tty/serial/atmel_serial.c
+++ b/drivers/tty/serial/atmel_serial.c
@@ -1734,6 +1734,7 @@ static void atmel_get_ip_name(struct uart_port *port)
 		switch (version) {
 		case 0x302:
 		case 0x10213:
+		case 0x10302:
 			dev_dbg(port->dev, "This version is usart\n");
 			atmel_port->has_frac_baudrate = true;
 			atmel_port->has_hw_timer = true;
-- 
2.14.1

Re: [PATCH] [PATCH] tty/serial: atmel: add new version check for usart

[Nicolas Ferre]

On 29/01/2018 at 12:39, Jonas Danielsson wrote:
> On our at91sam9260 based board the usart0 and usart1 ports report
> their versions (ATMEL_US_VERSION) as 0x10302. This version is not
> included in the current checks in the driver.
> 
> Signed-off-by: Jonas Danielsson <jonas@orbital-systems.com>

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

It must be the AT91SAM9260 rev. B SoC, isn't it?

Thanks for your patch.

Best regards,
  Nicolas

> ---
>  drivers/tty/serial/atmel_serial.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
> index efa25611ca0c..ae9f1dcbf3fc 100644
> --- a/drivers/tty/serial/atmel_serial.c
> +++ b/drivers/tty/serial/atmel_serial.c
> @@ -1734,6 +1734,7 @@ static void atmel_get_ip_name(struct uart_port *port)
>  		switch (version) {
>  		case 0x302:
>  		case 0x10213:
> +		case 0x10302:
>  			dev_dbg(port->dev, "This version is usart\n");
>  			atmel_port->has_frac_baudrate = true;
>  			atmel_port->has_hw_timer = true;
> 


-- 
Nicolas Ferre

Re: [PATCH] [PATCH] tty/serial: atmel: add new version check for usart

[Jonas Danielsson]

On Mon, Feb 5, 2018 at 1:36 PM, Nicolas Ferre
<nicolas.ferre@microchip.com> wrote:
> On 29/01/2018 at 12:39, Jonas Danielsson wrote:
>> On our at91sam9260 based board the usart0 and usart1 ports report
>> their versions (ATMEL_US_VERSION) as 0x10302. This version is not
>> included in the current checks in the driver.
>>
>> Signed-off-by: Jonas Danielsson <jonas@orbital-systems.com>
>
> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
>
> It must be the AT91SAM9260 rev. B SoC, isn't it?
>
> Thanks for your patch.
>
> Best regards,
>   Nicolas
>

Hi Nicolas!

Thank you for the review!

Yes that is right, we have the rev B SoC :) I Tried to find some
documentation online
regarding the US_VERSION register, but fell short.

Allt the best
Jonas

Re: [PATCH] [PATCH] tty/serial: atmel: add new version check for usart

[Nicolas Ferre]

On 05/02/2018 at 15:04, Jonas Danielsson wrote:
> On Mon, Feb 5, 2018 at 1:36 PM, Nicolas Ferre
> <nicolas.ferre@microchip.com> wrote:
>> On 29/01/2018 at 12:39, Jonas Danielsson wrote:
>>> On our at91sam9260 based board the usart0 and usart1 ports report
>>> their versions (ATMEL_US_VERSION) as 0x10302. This version is not
>>> included in the current checks in the driver.
>>>
>>> Signed-off-by: Jonas Danielsson <jonas@orbital-systems.com>
>>
>> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
>>
>> It must be the AT91SAM9260 rev. B SoC, isn't it?
>>
>> Thanks for your patch.
>>
>> Best regards,
>>   Nicolas
>>
> 
> Hi Nicolas!
> 
> Thank you for the review!
> 
> Yes that is right, we have the rev B SoC :) I Tried to find some
> documentation online
> regarding the US_VERSION register, but fell short.

It's actually a non-documented register ;-)
In short, bits [0-11] Hardware module version
bits [16-18] Metal fix number.
So your at91sam9260 revB benefit from the metal fix #1.

Best regards,
-- 
Nicolas Ferre

Re: [PATCH] [PATCH] tty/serial: atmel: add new version check for usart

[Richard Genoud]

2018-02-05 13:36 GMT+01:00 Nicolas Ferre <nicolas.ferre@microchip.com>:
> On 29/01/2018 at 12:39, Jonas Danielsson wrote:
>> On our at91sam9260 based board the usart0 and usart1 ports report
>> their versions (ATMEL_US_VERSION) as 0x10302. This version is not
>> included in the current checks in the driver.
>>
>> Signed-off-by: Jonas Danielsson <jonas@orbital-systems.com>
>
> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
>

Acked-by: Richard Genoud <richard.genoud@gmail.com>

> It must be the AT91SAM9260 rev. B SoC, isn't it?
>
> Thanks for your patch.
>
> Best regards,
>   Nicolas

Thanks !

Richard.