From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH v2] serial: pl011: honour serial aliases in device tree Date: Wed, 22 Aug 2012 00:04:23 +0200 Message-ID: References: <1345564094-16565-1-git-send-email-matthew.leach@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from mail-vc0-f174.google.com ([209.85.220.174]:51357 "EHLO mail-vc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758425Ab2HUWEY (ORCPT ); Tue, 21 Aug 2012 18:04:24 -0400 Received: by vcbfk26 with SMTP id fk26so376797vcb.19 for ; Tue, 21 Aug 2012 15:04:23 -0700 (PDT) In-Reply-To: <1345564094-16565-1-git-send-email-matthew.leach@arm.com> Sender: linux-serial-owner@vger.kernel.org List-Id: linux-serial@vger.kernel.org To: Matthew Leach Cc: linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org, will.deacon@arm.com, gregkh@linuxfoundation.org, devicetree-discuss@lists.ozlabs.org, robherring2@gmail.com On Tue, Aug 21, 2012 at 5:48 PM, Matthew Leach wrote: > If the order of UART nodes is changed in the device tree, then tty dev > devices are attached to different serial ports causing the console to > be directed to a different physical serial port. The "serial" aliases > in the device tree should prevent this. > > This patch ensures that the UART driver creates tty devices that > honour these aliases if a device tree is present. > > Acked-by: Rob Herring > Signed-off-by: Matthew Leach > --- > v2: use IS_ENABLED instead of ifdefs Looks good to me. Acked-by: Linus Walleij Yours, Linus Walleij