From mboxrd@z Thu Jan 1 00:00:00 1970 From: ttuttle Subject: Re: [PATCH 2/4] qcserial: log when an interface has too many altsettings Date: Wed, 1 Feb 2012 16:47:22 -0500 Message-ID: References: <20120201210723.GB16802@google.com> <20120201211116.GA30758@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20120201211116.GA30758-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Greg KH Cc: linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-serial@vger.kernel.org On Wed, Feb 1, 2012 at 16:11, Greg KH wrot= e: >> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 else if (serial->interfa= ce->num_altsetting > 2) { >> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 dev_err(&serial->dev->dev, >> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 "too many altsettings: %u", >> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 serial->interface->num_altsetting); > > Why would this happen? =C2=A0And what does spitting out an error do a= bout it? > What are we supposed to do with this information? This would happen if we found a device that was returning an unexpected USB configuration. We've never actually seen this happen -- it was just there in case. I can drop it if you think it's not worth the trouble. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html