From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yinghai Lu Subject: Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console() Date: Fri, 3 Apr 2015 17:58:03 -0700 Message-ID: References: <1425932842-21812-1-git-send-email-peter@hurleysoftware.com> <1425932842-21812-12-git-send-email-peter@hurleysoftware.com> <551CB5DF.1010108@hurleysoftware.com> <551D6EEA.6050704@hurleysoftware.com> <551E6D61.7000501@hurleysoftware.com> <551ED011.1030004@hurleysoftware.com> <551EDB92.9070008@hurleysoftware.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <551EDB92.9070008@hurleysoftware.com> Sender: linux-kernel-owner@vger.kernel.org To: Peter Hurley Cc: Andrew Morton , Greg Kroah-Hartman , Linux Kernel Mailing List , Jiri Slaby , Rob Herring , "linux-serial@vger.kernel.org" List-Id: linux-serial@vger.kernel.org On Fri, Apr 3, 2015 at 11:27 AM, Peter Hurley wrote: > On 04/03/2015 01:44 PM, Yinghai Lu wrote: > > which means you have to have CONFIG_SERIAL_EARLYCON to get a serial console > at all. what do you mean? Now in drivers/tty/serial/8250/Kconfig we have config SERIAL_8250_CONSOLE bool "Console on 8250/16550 and compatible serial port" depends on SERIAL_8250=y select SERIAL_CORE_CONSOLE select SERIAL_EARLYCON do you mean, we should not have that "select SERIAL_EARLYCON" ?