From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH] serial: 8250_lpss: Unconditionally set PCI master for Quark Date: Tue, 10 Jan 2017 01:24:53 +0200 Message-ID: References: <1d0224cc-10ee-df69-b383-c687e08ed44d@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Jan Kiszka Cc: Greg Kroah-Hartman , Andy Shevchenko , "linux-serial@vger.kernel.org" , Linux Kernel Mailing List List-Id: linux-serial@vger.kernel.org On Mon, Jan 9, 2017 at 7:11 PM, Jan Kiszka wrote: > On 2017-01-05 22:56, Andy Shevchenko wrote: >> On Thu, Jan 5, 2017 at 1:56 AM, Andy Shevchenko >> wrote: >> >> Ah, Jan, perhaps you would like to comment on this one as well >> http://marc.info/?l=linux-serial&m=148334902916347&w=2 >> ? >> > > http://marc.info/?l=linux-serial&m=148334905916354&w=2 enables MSI, but > that's only for Denverton, and there it is unconditional. So this is ok. I think there is potential issue, if DMA driver is not compiled or probed (by whatever reason) we will have MSI enabled without bus mastering. And like you said for sake of not copying wrong pattern for new API, would be good to move it. -- With Best Regards, Andy Shevchenko