From: Masahiro Yamada <yamada.masahiro@socionext.com>
To: linux-serial@vger.kernel.org
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
Arnd Bergmann <arnd@arndb.de>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Sekhar Nori <nsekhar@ti.com>, Jiri Slaby <jslaby@suse.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
David Lechner <david@lechnology.com>,
Thor Thayer <tthayer@opensource.altera.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] serial: of_serial: remove NULL pointer check for clk_disable_unprepare
Date: Sun, 21 May 2017 04:04:50 +0900 [thread overview]
Message-ID: <CAK7LNASoHTNeNWOX63S74bE6PrTsOce_rxtSiLkNypTPcSDJFA@mail.gmail.com> (raw)
In-Reply-To: <1495302286-1503-1-git-send-email-yamada.masahiro@socionext.com>
2017-05-21 2:44 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> After long term efforts of fixing non-common clock implementations,
> clk_disable() is a no-op for a NULL pointer input, and this is now
> tree-wide consistent.
>
> All clock consumers can safely call clk_disable(_unprepare) without
> NULL pointer check.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Sorry, I retract this patch.
Krzysztof pointed out
cleanups only for clk_disable_unprepare() will lose the code symmetry.
NULL pointer checks for clk_prepare_enable() should be
removed to keep the code symmetrical.
This is possible for common-clock framework because
clk_prepare_enable() is also a no-op for a NULL clk input.
But it is not necessarily true for non-common clock implementations.
--
Best Regards
Masahiro Yamada
prev parent reply other threads:[~2017-05-20 19:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-20 17:44 [PATCH] serial: of_serial: remove NULL pointer check for clk_disable_unprepare Masahiro Yamada
2017-05-20 19:04 ` Masahiro Yamada [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK7LNASoHTNeNWOX63S74bE6PrTsOce_rxtSiLkNypTPcSDJFA@mail.gmail.com \
--to=yamada.masahiro@socionext.com \
--cc=arnd@arndb.de \
--cc=david@lechnology.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=robert.jarzmik@free.fr \
--cc=tthayer@opensource.altera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).