Re: [PATCH v2 7/9] serdev: Introduce new bus for serial attached devices

[Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

On Wed, Jan 18, 2017 at 5:53 AM, Frédéric Danis
<frederic.danis.oss-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Hello,
>
> Le 16/01/2017 à 23:54, Rob Herring a écrit :
>>
>> ---
>> v2:
>> - Add modalias sysfs attr and uevent hook
>
> ...
>>
>> +static int serdev_uevent(struct device *dev, struct kobj_uevent_env *env)
>> +{
>> +       /* TODO: ACPI and platform modalias */
>> +       return of_device_uevent_modalias(dev, env);
>> +}
>
> ...
>>
>> +static ssize_t modalias_show(struct device *dev,
>> +                            struct device_attribute *attr, char *buf)
>> +{
>> +       ssize_t len = of_device_get_modalias(dev, buf, PAGE_SIZE - 2);
>> +       buf[len] = '\n';
>> +       buf[len+1] = 0;
>> +       return len+1;
>> +}
>
>
> This prevents from building serdev as a module with following errors:
>   ERROR: "of_device_uevent_modalias" [drivers/tty/serdev/serdev.ko]
> undefined!
>   ERROR: "of_device_get_modalias" [drivers/tty/serdev/serdev.ko] undefined!

Turns out, there's a fix already[1] that should be going in via Greg's tree.

Rob

[1] https://www.mail-archive.com/linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org/msg1299121.html