From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28B5BC433EF for ; Thu, 7 Jul 2022 08:48:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231350AbiGGIsD (ORCPT ); Thu, 7 Jul 2022 04:48:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234500AbiGGIsC (ORCPT ); Thu, 7 Jul 2022 04:48:02 -0400 Received: from mail-qt1-f171.google.com (mail-qt1-f171.google.com [209.85.160.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64C3E193CB; Thu, 7 Jul 2022 01:48:02 -0700 (PDT) Received: by mail-qt1-f171.google.com with SMTP id r2so1113334qtx.6; Thu, 07 Jul 2022 01:48:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7TC32F89z4NX+rauYaDqmY4874to+dNezztV+gLxaTs=; b=hRVqLg0Oooh1DXh2MqeVcinfVogN8otFAzemmWjcdhXXP98CqgfxYefd4GKYd2Oe6Y c2GkPzJLXU2GZkq4LS4lO+V/SYUtyYm1mpUF5gO0+maWPVWNo9FVCkwZXd0mdWRfI1a7 pgc2o/JwqsxGG0Bl4PMrxJGF3V4Jl+hO2tqN7+iykm7OEHhB1uTElrRdPt46TY82HL8L iONkGo3qwnVQnZ09jIqOeAgp5zBcA5ctfDNjj/W8ail+6xijG4MGrQjQkxeaV8h9fPIF u4hYLy+zipyDZbMaq8+nLyGt5KRj17lLQ63mvlvdk7KCyyzgrh6q3XlEhkIIjY083gI0 q+FA== X-Gm-Message-State: AJIora+M/Ybb8v2WTr2M02pbwGs8tXinTwdzrbuuhyztVOsjX5vpR4mV h7tr1RDz2qZh7UtyKg/4YLh6aDaOqzZS1Fyi X-Google-Smtp-Source: AGRyM1va1nZaq+qKAY2LeOfu11fNhu/mrf7/IRXNO9+3Dn1WglViDZK409KApapVTkhv6c/r7O3FCg== X-Received: by 2002:ad4:5765:0:b0:473:20f:fc09 with SMTP id r5-20020ad45765000000b00473020ffc09mr12618787qvx.2.1657183681250; Thu, 07 Jul 2022 01:48:01 -0700 (PDT) Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com. [209.85.128.181]) by smtp.gmail.com with ESMTPSA id bl10-20020a05620a1a8a00b006a67eb4610fsm32116402qkb.116.2022.07.07.01.48.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 Jul 2022 01:48:01 -0700 (PDT) Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-317a66d62dfso163467067b3.7; Thu, 07 Jul 2022 01:48:00 -0700 (PDT) X-Received: by 2002:a0d:dd09:0:b0:31c:e3b9:7442 with SMTP id g9-20020a0ddd09000000b0031ce3b97442mr10302814ywe.47.1657183680441; Thu, 07 Jul 2022 01:48:00 -0700 (PDT) MIME-Version: 1.0 References: <20220630140919.3857698-1-yangyingliang@huawei.com> In-Reply-To: <20220630140919.3857698-1-yangyingliang@huawei.com> From: Geert Uytterhoeven Date: Thu, 7 Jul 2022 10:47:49 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/2] serial: sh-sci: fix missing sci_cleanup_single() in sci_probe_single() To: Yang Yingliang Cc: Linux Kernel Mailing List , "open list:SERIAL DRIVERS" , Greg KH , Peter Hurley , Sjoerd Simons Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Thu, Jun 30, 2022 at 3:59 PM Yang Yingliang wrote: > Add missing sci_cleanup_single() in error case in sci_probe_single() > > Fixes: f907c9ea8835 ("serial: sh-sci: Add support for GPIO-controlled modem lines") > Reported-by: Hulk Robot > Signed-off-by: Yang Yingliang Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds