* Re: [PATCH] sh-sci: SysRq support on EARLYCON
[not found] <1461772153-6785-1-git-send-email-ysato@users.sourceforge.jp>
@ 2016-05-25 13:24 ` Geert Uytterhoeven
0 siblings, 0 replies; only message in thread
From: Geert Uytterhoeven @ 2016-05-25 13:24 UTC (permalink / raw)
To: Yoshinori Sato
Cc: linux-renesas-soc, Linux-sh list, linux-serial@vger.kernel.org
Hi Sato-san,
CC linux-serial
On Wed, Apr 27, 2016 at 5:49 PM, Yoshinori Sato
<ysato@users.sourceforge.jp> wrote:
> Add missing flag condition.
>
> Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>
Unfortunately magic SysRq only works if CONFIG_SERIAL_SH_SCI_DMA=n.
> ---
> drivers/tty/serial/sh-sci.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
> index 0130feb..5a73620 100644
> --- a/drivers/tty/serial/sh-sci.c
> +++ b/drivers/tty/serial/sh-sci.c
> @@ -18,7 +18,9 @@
> * License. See the file "COPYING" in the main directory of this archive
> * for more details.
> */
> -#if defined(CONFIG_SERIAL_SH_SCI_CONSOLE) && defined(CONFIG_MAGIC_SYSRQ)
> +#if (defined(CONFIG_SERIAL_SH_SCI_CONSOLE) || \
> + defined(CONFIG_SERIAL_SH_SCI_EARLYCON)) && \
> + defined(CONFIG_MAGIC_SYSRQ)
> #define SUPPORT_SYSRQ
> #endif
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-05-25 13:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1461772153-6785-1-git-send-email-ysato@users.sourceforge.jp>
2016-05-25 13:24 ` [PATCH] sh-sci: SysRq support on EARLYCON Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).