From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="BPvuM+nE" Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::228]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5911A173A; Thu, 7 Dec 2023 09:58:25 -0800 (PST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 50ED81BF20D; Thu, 7 Dec 2023 17:58:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1701971903; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ztrqr2r+NdGGR17MQHZJfBYqrLR90ks+eNJU1UUR484=; b=BPvuM+nEK1j7qHnJ+Jq4urfc+MAFM7wsIQRL9vOmCGapoIbcgM3x6O4ttn155bCQoAFsB2 e2wUr9Alq0uET6He5daVB/IHufexQwpI0MkJopgOc4OvovUHTETfP0kPasGmxDN8+S0dNI OKPS+bv5gbtpxkcn8EWHcpbbAfz4IsL2wPSKdJ9g8NNylm8fCJ43e9c0xFWykY52tocyIL 5+LFGLc1G7vU6By0RqUlVfU74saXZH31nJgxJRllWqQASxk7F8mXHuN83zjvF2Fhng/ogj I8mVfFMS5As3J5EOr1217b7pV7WrSm6EVU768zWgEobD7sia8vIj/VCT7ci4kw== Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Thu, 07 Dec 2023 18:58:12 +0100 Message-Id: Cc: "Greg Kroah-Hartman" , "Russell King" , "Jiri Slaby" , "LKML" , "linux-serial" , "Linus Walleij" , =?utf-8?q?Gr=C3=A9gory_Clement?= , "Alexandre Belloni" , "Thomas Petazzoni" , "Vladimir Kondratiev" , "Tawfik Bayouk" To: =?utf-8?q?Ilpo_J=C3=A4rvinen?= From: =?utf-8?q?Th=C3=A9o_Lebrun?= Subject: Re: [PATCH v5 2/9] tty: serial: amba: Use linux/{bits,bitfield}.h macros X-Mailer: aerc 0.15.2 References: <20231130-mbly-uart-v5-0-6566703a04b5@bootlin.com> <20231130-mbly-uart-v5-2-6566703a04b5@bootlin.com> <2023120742-argue-slighting-6120@gregkh> <42e8faf-5293-18e4-3877-25e4d094f1d@linux.intel.com> In-Reply-To: <42e8faf-5293-18e4-3877-25e4d094f1d@linux.intel.com> X-GND-Sasl: theo.lebrun@bootlin.com Hello, On Thu Dec 7, 2023 at 10:56 AM CET, Ilpo J=C3=A4rvinen wrote: > On Thu, 7 Dec 2023, Th=C3=A9o Lebrun wrote: > > On Thu Dec 7, 2023 at 2:37 AM CET, Greg Kroah-Hartman wrote: > > > On Thu, Nov 30, 2023 at 03:07:14PM +0100, Th=C3=A9o Lebrun wrote: > > > > The driver uses bit shifts and hexadecimal expressions to declare > > > > constants. Replace that with the BIT(), GENMASK() & FIELD_PREP_CONS= T() > > > > macros to clarify intent. > > > >=20 > > > > Reviewed-by: Linus Walleij > > > > Reviewed-by: Ilpo J=C3=A4rvinen > > > > Signed-off-by: Th=C3=A9o Lebrun > > > > --- > > > > include/linux/amba/serial.h | 248 +++++++++++++++++++++++---------= ------------ > > > > 1 file changed, 127 insertions(+), 121 deletions(-) > > > > > > As 0-day had a problem with this patch, I've applied only patch 1 of > > > this series. Can you fix it up and rebase and resend the rest again > > > (while adding the collected reviewed-by that some patches in this ser= ies > > > had)? > >=20 > > So the issue is this: the header file gets included in > > arch/arm/include/debug/pl01x.S that gets included in arch/arm/kernel/de= bug.S > > (see #include CONFIG_DEBUG_LL_INCLUDE). > >=20 > > I don't see any easy way out of this, so I guess it means the patch mus= t be > > dropped. If someone confirms that there are indeed no solution to have = BIT(), > > GENMASK() & FIELD_PREP_CONST() accessible from assembly, I'll send the = next > > version. > > Yeah, it seems to require UART01x_FR_TXFF and UART01x_FR_BUSY, plus=20 > UART01x_DR and UART01x_FR that are not touched by your patch. > > I suppose the rest might be convertable though.. Thanks Greg and Ilpo! v6 has been sent. Regards, -- Th=C3=A9o Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com