Re: [PATCH] serial: sirf: fix line over 80 characters style issue

[Barry Song <21cnbao@gmail.com>]

On 14-9-9 上午9:33, "Greg KH" <gregkh@linuxfoundation.org> wrote:

>On Tue, Sep 09, 2014 at 08:16:47AM +0800, Barry Song wrote:
>> 
>> 
>> On 14-9-9 上午7:15, "Greg KH" <gregkh@linuxfoundation.org> wrote:
>> 
>> >On Mon, Aug 18, 2014 at 05:32:52PM +0800, Barry Song wrote:
>> >> From: Qipan Li <Qipan.Li@csr.com>
>> >> 
>> >> According to key customer's requirement, fix "line over 80
>> >> characters".
>> >
>> >Someone is forcing you to fix all upstream kernel.org code for 80
>> >columns?  Who?
>> 
>> we were asked to fix csr platform codes some days ago. They have been
>> fixed locally. 
>
>What is "locally"?
>
>And you really are forced to do foolish cleanups for no reason in
>mainline kernel code for no reason?

"Locally" means the code tree in our local git repo. Nobody asked me to
cleanup all mainline codes, the asked changes are for sirf platform codes
whose authors are sirf platform engineers.

>
>> You know, the difficulty is maintaining the difference between
>> mainline and local codes.
>> So I thought this is better if you can merge it.
>
>I'm not taking stuff that isn't correct.  Or is foolish.  Neither should
>you.

Never. I always think we need to make codes have good readability.

>
>> >Sorry, not going to take this, if your customer blames you, point them
>> >at me.
>> 
>> I understand you are very helpful. But pointing them to you will
>>actually
>> make things worse as I think we have no chance to convince them as we
>>have
>> tried our best to do that.
>> The benefit of this patch is making people happy. But if you are not
>> happy, I can make myself unhappy to maintain two versions.
>
>Try fixing the code to look better, your changes were not valid ones,
>you are quieting some automatic tool checker, you aren't doing the
>correct thing and following the "spirit" of the rule here.
>
>Make the code look cleaner, and I'll be glad to take the change.

As you said, most old codes looks better with "line over 80 chars", so I
would like to know what is the way you are happy. Is it fixing all "line
over 80 chars" with changes following the "spirit", or only splitting
those lines which will follow "spirit" better if we split them.
If the lines over 80 chars have been good and following the "spirit", do
they need to be fixed?

>
>greg k-h

-barry


--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html